FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-143148: Replace pre-commit with prek in CI by juhannc · Pull Request #143149 · python/cpython · GitHub

/ cpython Public

gh-143148: Replace pre-commit with prek in CI - #143149

Merged
hugovk merged 5 commits into
python:mainfrom
juhannc:gh-143148-prek
Jan 2, 2026
ConversationCommits (5)ChecksFiles changed
Merged

gh-143148: Replace pre-commit with prek in CI#143149
hugovk merged 5 commits into
python:mainfrom
juhannc:gh-143148-prek

Conversation

juhannc commented Dec 24, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot commented Dec 24, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

python-cla-bot Bot commented Dec 24, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot mentioned this pull request Dec 24, 2025
Closed

bedevere-app Bot commented Dec 25, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

juhannc added a commit to juhannc/devguide that referenced this pull request Dec 25, 2025
docs: reflect changes of python/cpython#143149
ac93772
juhannc mentioned this pull request Dec 25, 2025
Open
picnixz requested changes Dec 30, 2025
View reviewed changes

picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As I said on the issue, I'm against that change if I need to install prek.

bedevere-app Bot commented Dec 30, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

picnixz commented Dec 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

In addition, I believe such changes requires a NEWS entry (if we were to do it, and however we do it).

picnixz removed the skip news label Dec 30, 2025

bedevere-app Bot commented Dec 30, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

hugovk reviewed Dec 30, 2025
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Alright, let's undo the changes to Makefile in this PR, and just update the CI in this one.

Then we can decide on the Makefile changes in another one.

Comment thread Doc/Makefile Outdated
Comment thread Doc/Makefile Outdated
Apply suggestions from code review
fef4655 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

bedevere-app Bot commented Dec 31, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

AA-Turner reviewed Dec 31, 2025
View reviewed changes
Comment thread Doc/Makefile Outdated
picnixz added the infra CI, GitHub Actions, buildbots, Dependabot, etc. label Dec 31, 2025

AA-Turner commented Dec 31, 2025

Copy link
Copy Markdown
Member

I am a little surprised that the action e.g. uses os.execvp (https://github.com/j178/prek-action/blob/main/action.yaml). One option for explitictness (especially in this repo) would be to download & run the prek-installer.sh without the indirection of the action.

A

hugovk commented Jan 2, 2026

Copy link
Copy Markdown
Member

Let's use the action to simplify maintenance, but please do make suggestions upstream.

hugovk merged commit 864c598 into python:main Jan 2, 2026
86 of 89 checks passed
hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 2, 2026

miss-islington-app Bot commented Jan 2, 2026

Copy link
Copy Markdown

Thanks @juhannc for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app Bot commented Jan 2, 2026

Copy link
Copy Markdown

Thanks @juhannc for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2026
pythongh-143148: Replace pre-commit with prek in CI (pythonGH-143149)
3b6f317 
(cherry picked from commit 864c598)

Co-authored-by: Johann Christensen <johannchristensen@outlook.de>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

bedevere-app Bot commented Jan 2, 2026

Copy link
Copy Markdown

GH-143359 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jan 2, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2026
pythongh-143148: Replace pre-commit with prek in CI (pythonGH-143149)
d134301 
(cherry picked from commit 864c598)

Co-authored-by: Johann Christensen <johannchristensen@outlook.de>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

bedevere-app Bot commented Jan 2, 2026

Copy link
Copy Markdown

GH-143360 is a backport of this pull request to the 3.14 branch.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jan 2, 2026
hugovk added a commit that referenced this pull request Jan 2, 2026
[3.13] gh-143148: Replace pre-commit with prek in CI (GH-143149) (#14…
08c5bfe 
…3359)

Co-authored-by: Johann Christensen <johannchristensen@outlook.de>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
hugovk added a commit that referenced this pull request Jan 2, 2026
[3.14] gh-143148: Replace pre-commit with prek in CI (GH-143149) (#14…
935a366 
…3360)

Co-authored-by: Johann Christensen <johannchristensen@outlook.de>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This was referenced Jan 2, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
ulgens mentioned this pull request Jan 3, 2026
Merged
hugovk mentioned this pull request Jan 11, 2026
Merged
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
pythongh-143148: Replace pre-commit with prek in CI (python#143149)
d6d40dc 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
DimitriPapadopoulos mentioned this pull request Mar 4, 2026
Closed
vivodi mentioned this pull request Mar 23, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes
AA-Turner AA-Turner left review comments
StanFromIreland StanFromIreland left review comments
picnixz picnixz approved these changes
ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

No one assigned

Labels

infra CI, GitHub Actions, buildbots, Dependabot, etc. skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace pre-commit with prek for faster linting

5 participants

Back | FazBrowse Home | New Git URL