gh-149132: Add module keyword argument to typing.TypeAliasType - #149133
Closed
ericmarkmartin wants to merge 1 commit into
Closed
gh-149132: Add module keyword argument to typing.TypeAliasType#149133ericmarkmartin wants to merge 1 commit into
ericmarkmartin wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ericmarkmartin
requested review from
AlexWaygood and
JelleZijlstra
as code owners
April 29, 2026 05:49
Copy link
Copy Markdown
|
All commit authors signed the Contributor License Agreement. |
Sorry, something went wrong.
ericmarkmartin
force-pushed
the
typealiastype-module-kwarg
branch
from
5ddb9d6 to
eb3597c
Compare
April 29, 2026 05:53
Copy link
Copy Markdown
Documentation build overview3 files changed ± download.html ± library/typing.html ± whatsnew/changelog.html |
Sorry, something went wrong.
sobolevn
reviewed
Apr 29, 2026
sobolevn
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I see a good point in adding this parameter :)
Sorry, something went wrong.
Comment thread
Lib/test/test_type_aliases.py
| ns, | ||
| ns, | ||
| ) | ||
| self.assertEqual(ns["TA"].__module__, "x.y") |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Please, test repr with the custom module, we want to be sure that there will no regression there.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Added!
Sorry, something went wrong.
Add an optional keyword-only `module` argument to `typing.TypeAliasType` that overrides the `__module__` attribute inferred by frame introspection. When omitted, behavior is unchanged. closes python#149132.
ericmarkmartin
force-pushed
the
typealiastype-module-kwarg
branch
from
eb3597c to
6a48187
Compare
April 29, 2026 21:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional keyword-only module argument to
typing.TypeAliasType that overrides the __module__ attribute inferred by frame introspection. When omitted, behavior is unchanged.
closes #149132.