gh-156243: Indicate that emscripten_runtime depends on stringToNewUTF8 - #156335
Merged
freakboy3742 merged 1 commit intoAug 25, 2026
Merged
gh-156243: Indicate that emscripten_runtime depends on stringToNewUTF8#156335freakboy3742 merged 1 commit into
freakboy3742 merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…epends on stringToNewUTF8
hoodmane
requested review from
freakboy3742
and removed request for
ericsnowcurrently
August 24, 2026 21:16
freakboy3742
approved these changes
Aug 25, 2026
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Makes sense to me.
@hoodmane Given the original report was against 3.15.0rc1, I presume this should be back ported to at least 3.15, and possibly 3.14 as well to 3.15 (3.14 doesn't appear to have the affected code)?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Agreed, I added a "needs backport" label. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
GH-156383 is a backport of this pull request to the 3.15 branch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #156243.