| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Documentation build overview21 files changed · ± 21 modified ± Modified |
Sorry, something went wrong.
|
Ah, my apologies! I created this branch from my fork's main branch without syncing with upstream/main first, which accidentally dragged in some unrelated commits from another PR I was working on. I have just rebased and force-pushed to clean it up. It should only contain the Windows instructions for pomerge now. Let me know if everything looks good! |
Sorry, something went wrong.
There was a problem hiding this comment.
The commands look reasonable to me, assuming that pomerge is available and working the same way on Windows.
I haven't tried this out, I'm hoping you have run this successfully? :)
Sorry, something went wrong.
|
Thanks for the review and approval! Yes, I can confirm the standard shell commands (xcopy, rmdir, git checkout) work perfectly in the Windows Command Prompt. Since pomerge is a Python tool, it uses Python's built-in glob which natively handles the **\*.po globbing patterns on Windows just as well as it does on Unix! 😄 |
Sorry, something went wrong.
|
@tomasr8 topic-sprints is for docs on how to organise/run sprints. I’ve just created a sprint label for PRs being worked on at a sprint, like in CPython. |
Sorry, something went wrong.
There was a problem hiding this comment.
Can you please add the .. include:: /include/activate-tab.rst to the top of the file like we have elsewhere.
Sorry, something went wrong.
|
Done! Added the activate-tab.rst include to the top of the file. |
Sorry, something went wrong.
Haha yeah I figured, sorry about that! I just wanted a temporary label so I could keep track of the issues :) Thanks for adding the label! |
Sorry, something went wrong.
|
I'll be at a Windows computer next week, if it helps. |
Sorry, something went wrong.
|
@StanFromIreland good catch from Claude! You're totally right, cmd.exe doesn't expand wildcards so the previous command would just crash. I've updated the dosbatch instructions to use a standard for /R loop instead. This passes the files to pomerge one by one, which works perfectly since it saves its translation memory iteratively. I also added shopt -s globstar to the Unix tab, since Bash actually needs that flag enabled for **/*.po to work recursively too. Thanks for pointing this out! |
Sorry, something went wrong.
|
@StanFromIreland Excellent catch on the translation memory overwrite! You are absolutely right; pomerge overwrites ~/.pomerge.json on every invocation, so looping through files one-by-one is completely broken. I've pushed a fix that replaces the Windows dosbatch tab entirely with a powershell script. By using PowerShell's Get-ChildItem, we can natively expand the wildcards into an array and pass all files to pomerge in a single invocation, bypassing the overwrite issue completely while avoiding the lack of native globbing in cmd.exe. I've also applied your suggested comment to the Unix tab! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Fixes #1783
This PR adds the missing Windows commands tab for the pomerge translation recovery tool, resolving the TODO in translating.rst. The commands for Windows use xcopy and rmdir to achieve the same result as the Unix cp and rm.