Repository navigation
Handle corner case: protocol vs classvar vs descriptor - #19277
Merged
ilevkivskyi merged 3 commits intoJun 13, 2025
Merged
ilevkivskyi merged 3 commits into
ilevkivskyi merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This comment has been minimized.
JukkaL
approved these changes
Jun 11, 2025
JukkaL
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
This looks reasonable as a short-term fix . We can continue supporting this use case, though users will have to add an explicit ClassVar annotation.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
What about mentioning this in the documentation? This may be non-obvious for users. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Good point! I will add the docs later today. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
Closed
esarp
pushed a commit
that referenced
this pull request
Jul 3, 2025
Ref #19274 This is a bit ugly. But I propose to have this "hot-fix" until we have a proper overhaul of instance vs class variables. To be clear: attribute access already works correctly (on both `P` and `Type[P]`), but subtyping returns false because of ```python elif (IS_CLASSVAR in subflags) != (IS_CLASSVAR in superflags): return False ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #19274
This is a bit ugly. But I propose to have this "hot-fix" until we have a proper overhaul of instance vs class variables. To be clear: attribute access already works correctly (on both P and Type[P]), but subtyping returns false because of