Repository navigation
Subtype checking micro-optimization - #19384
Merged
hauntsaninja merged 1 commit intoJul 6, 2025
Merged
hauntsaninja merged 1 commit into
hauntsaninja merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Speeds up self-check by about 0.6%. The assertion is very hot, and the original version always created a set, which is slow.
Copy link
Copy Markdown
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sorry, something went wrong.
JelleZijlstra
approved these changes
Jul 6, 2025
hauntsaninja
approved these changes
Jul 6, 2025
Copy link
Copy Markdown
Collaborator
|
There's an assert of exactly same form in is_proper_subtype, is it also worth rewriting? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@sterliakov Yes, that one should be rewritten as well (it is probably less hot, but still worth doing). |
Sorry, something went wrong.
JukkaL
added a commit
that referenced
this pull request
Jul 16, 2025
…#19463) This was suggested by @sterliakov in #19384 (comment) This is a part of a set of micro-optimizations that improve self check performance by ~5.5%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speeds up self-check by about 0.6%. The assertion is very hot, and the original version always created a set, which is slow.