FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Two more micro-optimizations by ilevkivskyi · Pull Request #19627 · python/mypy · GitHub

  1. python
  2. mypy

Repository navigation

Two more micro-optimizations - #19627

Merged
ilevkivskyi merged 1 commit into
python:masterfrom
ilevkivskyi:twop-more-opts
Aug 9, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Two more micro-optimizations#19627
ilevkivskyi merged 1 commit into
python:masterfrom
ilevkivskyi:twop-more-opts

Conversation

ilevkivskyi commented Aug 9, 2025

Copy link
Copy Markdown
Member

This has two things (totalling 1.5% locally, but see caveat below):

  • Do not use @contextmanger (that is relatively slow) for local_type_map, since it appears in multiple hot paths.
  • Do not show name suggestions for import errors in third party packages (since those errors are ignored anyway). It calls difflib that can be extremely slow with large modules.

Btw the second will probably not affect self-check, although it did affect my self-check, since apparently pytest depends on numpy. Well, they don't specify it as a package dependency, but https://github.com/pytest-dev/pytest/blob/main/src/_pytest/python_api.py#L17-L18

if TYPE_CHECKING:
    from numpy import ndarray

(and I have numpy installed in all my environments, LOL)

github-actions Bot commented Aug 9, 2025

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

ilevkivskyi commented Aug 9, 2025

Copy link
Copy Markdown
Member Author

Btw just wanted to brag about how stable is my local bench:

master                    3.810s (0.0%)  | stdev 0.008s 
twop-more-opts            3.756s (-1.4%) | stdev 0.008s

(you read that right, standard deviation is just 8 milliseconds)

sterliakov approved these changes Aug 9, 2025
View reviewed changes

sterliakov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice one! Please post this to plugin API announcements - I expect some plugins in wild might use this functionality (yes, undocumented, yes, private, let's just do that and let people know something might break).

since apparently pytest depends on numpy

Now that was interesting.

ilevkivskyi merged commit 660d911 into python:master Aug 9, 2025
ilevkivskyi deleted the twop-more-opts branch August 9, 2025 18:47
ilevkivskyi mentioned this pull request Aug 9, 2025
Open
hauntsaninja mentioned this pull request Sep 10, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JukkaL Awaiting requested review from JukkaL
hauntsaninja Awaiting requested review from hauntsaninja
1 more reviewer
sterliakov sterliakov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL