FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use --config-settings in external libraries list in installation.rst by nulano · Pull Request #7564 · python-pillow/Pillow · GitHub

Use --config-settings in external libraries list in installation.rst - #7564

Merged
hugovk merged 2 commits into
python-pillow:mainfrom
nulano:config-docs
Nov 20, 2023
Merged

Use --config-settings in external libraries list in installation.rst#7564
hugovk merged 2 commits into
python-pillow:mainfrom
nulano:config-docs

Conversation

nulano commented Nov 20, 2023

Copy link
Copy Markdown
Contributor

These two references to the build flags were missed in #7171.

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

hugovk added the automerge Automatically merge PRs that are ready label Nov 20, 2023

Copy link
Copy Markdown
Member

I feel a bit weird about

Starting with Pillow 3.0.0, libjpeg is required by default, but may be disabled with the -C jpeg=disable flag.

since "libjpeg is required by default" is since Pillow 3.0.0, but -C jpeg=disable isn't until much later. My suggestion is to split this into two sentences? nulano#24

hugovk removed the automerge Automatically merge PRs that are ready label Nov 20, 2023
hugovk merged commit 9694cfc into python-pillow:main Nov 20, 2023
nulano deleted the config-docs branch November 20, 2023 22:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL