test: add benchmarks for ipaddress object creation and hashing - #1773
Merged
bdraco merged 1 commit intoMay 24, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1773 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 33 33
Lines 3536 3536
Branches 498 498
=======================================
Hits 3528 3528
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Merging this PR will not alter performance✅ 14 untouched benchmarks Performance Changes
Comparing bluetoothbot:koan/bench-ipaddress-creation (433dd40) with master (cb81e67) |
Sorry, something went wrong.
bdraco
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add CodSpeed benchmarks for ZeroconfIPv4Address / ZeroconfIPv6Address construction and hashing.
Why
get_ip_address_object_from_record builds one of these objects per A/AAAA record on a cache miss, and the objects are hashed when stored in sets/dicts. There is currently no benchmark guarding the construction or hash cost of this hot path, so regressions (or improvements) go unmeasured.
This establishes the baseline before a follow-up that reworks how the per-instance hash is cached.
How
Four benchmarks under tests/benchmarks/test_ipaddress.py:
Testing
SKIP_CYTHON=1 poetry run pytest tests/benchmarks/test_ipaddress.py -v — 4 passed. ruff + ruff-format clean.