fix(tanstack-start): pin solid-js to 1.x for devtools peer - #496
Merged
stormslowly merged 1 commit intoAug 21, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
@tanstack/devtools declares `solid-js: >=1.9.7` as a peer dependency, so a full re-resolution dedupes it onto the workspace's solid-js@2.0.0-rc.0 (introduced by #495 for the Rsbuild Solid example) instead of its own `solid-js: ^1.9.9` dependency. Solid 2 dropped `onMount`/`batch`/`on`/ `getListener` and the `./web` subpath export, breaking the build. Declaring solid-js explicitly pins this example's subtree back to 1.x without touching the Solid example.
stormslowly
marked this pull request as draft
August 21, 2026 08:29
chenjiahan
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The rspack ecosystem CI run fails at build:rsbuild on rsbuild/tanstack-start with 64 module linking errors:
@tanstack/devtools declares solid-js: >=1.9.7 as a peer dependency. Since #495 introduced solid-js@2.0.0-rc.0 into the workspace, a full re-resolution (which ecosystem CI triggers by injecting @rspack/* overrides) dedupes that peer onto 2.0.0-rc.0 instead of the package's own solid-js: ^1.9.9 dependency. Solid 2 removed onMount / batch / on / getListener and the ./web subpath export, so the devtools bundle no longer links.
Before / after, same install (pnpm install --prefer-frozen-lockfile with @rspack/* overrides injected):
What
Declare solid-js: ^1.9.9 in rsbuild/tanstack-start, so this example provides the peer itself and its subtree stays on Solid 1.x. The Solid 2 RC in rsbuild/solid is untouched.
Rejected alternatives: dedupePeers: false (does not change the resolution), and a workspace-wide solid-js override (would downgrade the Solid example and undo #495).
Verified locally by running the full ecosystem CI sequence — build:rspack:eco-ci, test:rspack:eco-ci, build:rsbuild, build:rsdoctor, build:rspress, build:rslib — plus pnpm lint.