perf: bypass unused readonly file system overlay - #135
chenjiahan merged 1 commit into
Conversation
Sorry, something went wrong.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 873c1433-19fd-47db-bdba-c53ef0d8b8e1 📥 CommitsReviewing files that changed from the base of the PR and between a112746 and f356980. 📒 Files selected for processing (3)
📝 Walkthrough WalkthroughAdds change tracking to the in-memory filesystem and exposes it through hasChanges(). Readonly filesystem selection now uses the real filesystem when memory is unchanged and the passive overlay after memory mutations. New unit tests cover readonly routing, write-tsbuildinfo overlay behavior, and restoration of virtual files after deletion. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
Summary
Readonly checks previously routed every file read through the passive disk/memory overlay, even before the in-memory file system contained any output. This PR reads directly from disk while the readonly memory layer is clean, then conservatively restores the overlay after its first mutation so SolutionBuilder can still consume generated reference artifacts. Other write modes and artifact handling remain unchanged.
Performance
Measured on Node.js v24.12.0 with 2 warmups and 7 interleaved A/B runs per case, comparing a112746 with this branch:
The optimized build won all 21 paired runs. In the react-5k call profile, normalizePath calls fell by 44.6% and realpathSync calls fell by 36.1%; the interleaved timings above are the primary performance evidence.
Validation
Related Links