FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Handle null values while parsing double and float by Szczurowsky · Pull Request #57 · simdjson/simdjson-java · GitHub

/ simdjson-java Public

Handle null values while parsing double and float - #57

Open
Szczurowsky wants to merge 1 commit into
simdjson:mainfrom
Szczurowsky:handle-null-values
ConversationCommits (1)ChecksFiles changed
Open

Handle null values while parsing double and float#57
Szczurowsky wants to merge 1 commit into
simdjson:mainfrom
Szczurowsky:handle-null-values

Conversation

Szczurowsky commented Aug 30, 2024

Copy link
Copy Markdown

When you try to parse JSON that has field with type (for ex.) double and value of that field is null, then it throws and exception.
That PR will allow such value for Double and Float, since they have value NaN that fits for that purpose.

Szczurowsky changed the title handle null values while parsing double and float Handle null values while parsing double and float Aug 30, 2024

piotrrzysko commented Oct 20, 2024

Copy link
Copy Markdown
Member

Thanks for the PR. A couple of comments:

  1. It would be good to add a test for this.
  2. I'm not sure why the parser should return NaN in this case. If a field is defined as float (not Float), and the JSON contains null for that field, it seems like an error that shouldn't be hidden.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL