refactor: setup the logger using core configuration values - #408
Merged
zimeg merged 3 commits intoMar 12, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #408 +/- ##
==========================================
+ Coverage 99.70% 99.85% +0.15%
==========================================
Files 6 7 +1
Lines 669 699 +30
==========================================
+ Hits 667 698 +31
+ Misses 2 1 -1 ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
2 tasks
WilliamBergamin
approved these changes
Mar 12, 2025
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I like this 💯 nice job
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@WilliamBergamin Thanks so much! I'm hoping this logger might find use elsewhere too, but I'm most excited for the testing improvements TBH 🌲 ✨ |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the logger setup used for @slack/web-api to a standalone file to test that the configured action inputs are used when constructing the WebClient 👾
Hopefully no changes to functionality, but an improvement to testing for following changes!
Requirements