Fix CI lint script to lint all charts - #930
Open
marcleblanc2 wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
- lint_chart exited the whole script after the first chart, so only charts/sourcegraph was ever linted; migrator and executor were skipped - charts/sourcegraph-executor is a parent directory of two charts (k8s, dind), not a chart, so its lint line would have failed anyway - Lint each executor chart directly, with --set executor.queueName so the templates render instead of warning on empty metadata.name - Lint every chart even after a failure, report per-chart results, and exit with the first failing status Amp-Thread-ID: https://ampcode.com/threads/T-01a04192-5b1d-7040-9dc3-76f8d5a10ab0 Co-authored-by: Amp <amp@ampcode.com>
marcleblanc2
enabled auto-merge (squash)
August 27, 2026 05:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amp-Thread-ID: https://ampcode.com/threads/T-01a04192-5b1d-7040-9dc3-76f8d5a10ab0
Checklist
Test plan
Before
After