Add select by type - #771
Open
ngungbi wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
added 2 commits
December 17, 2025 22:39
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
Adds a generic Query.Select<T>() API to infer selected columns from a CLR type’s public properties (with optional [Column] attribute mapping), along with tests validating the generated SQL for PostgreSQL.
Changes:
- Added Query.Select<T>() to build a select list from reflected properties, supporting [Column] for col AS Alias.
- Added unit tests for selecting by type and for [Column]-driven column aliasing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| QueryBuilder/Query.Select.cs | Introduces Select<T>() implementation using reflection and [Column] attributes. |
| QueryBuilder.Tests/SelectTests.cs | Adds tests to validate generated SQL for Select<T>() with and without [Column]. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
QueryBuilder/Query.Select.cs
Comment on lines
+122
to
+137
| public Query Select<T>() where T : class { | ||
| var properties = typeof(T).GetProperties(); | ||
| var columns = new List<string>(); | ||
| foreach (var property in properties) { | ||
| if (property.GetSetMethod() == null) { | ||
| continue; | ||
| } | ||
|
|
||
| var name = property.Name; | ||
| var attribute = property.GetCustomAttribute<ColumnAttribute>(); | ||
| if (attribute != null) { | ||
| name = $"{attribute.Name} as {name}"; | ||
| } | ||
|
|
||
| columns.Add(name); | ||
| } |
Comment thread
QueryBuilder/Query.Select.cs
Comment on lines
+125
to
+128
| foreach (var property in properties) { | ||
| if (property.GetSetMethod() == null) { | ||
| continue; | ||
| } |
Comment thread
QueryBuilder/Query.Select.cs
| } | ||
|
|
||
| public Query Select<T>() where T : class { | ||
| var properties = typeof(T).GetProperties(); |
Comment thread
QueryBuilder/Query.Select.cs
Comment on lines
+122
to
+124
| public Query Select<T>() where T : class { | ||
| var properties = typeof(T).GetProperties(); | ||
| var columns = new List<string>(); |
Comment thread
QueryBuilder.Tests/SelectTests.cs
Comment on lines
+964
to
+971
| public void SelectType() { | ||
| var q = new Query("Post").Select<Post>(); | ||
|
|
||
| var pgsql = Compilers.CompileFor(EngineCodes.PostgreSql, q); | ||
|
|
||
| Assert.Equal(""" | ||
| SELECT "Id", "Title", "Published" FROM "Post" | ||
| """, pgsql.ToString()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Select<T>() to automatically add all the properties of a class into select component.