FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: migrate `math/base/special/gammaincinv` to ULP-based assertions by aryan7071 · Pull Request #14752 · stdlib-js/stdlib · GitHub

/ stdlib Public

test: migrate math/base/special/gammaincinv to ULP-based assertions - #14752

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
aryan7071:test-migrate-gammaincinv
Aug 28, 2026
ConversationCommits (2)ChecksFiles changed
Merged

test: migrate math/base/special/gammaincinv to ULP-based assertions#14752
kgryte merged 2 commits into
stdlib-js:developfrom
aryan7071:test-migrate-gammaincinv

Conversation

aryan7071 commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves a part of #11352

Description

What is the purpose of this pull request?

This pull request:

  • migrates the test suite for math/base/special/gammaincinv from relative tolerance (abs-based) assertions to ULP difference assertions using @stdlib/assert/is-almost-same-value.
  • updates test/test.js only. test/test.native.js was already migrated to ULP-based testing prior to this PR and is unchanged.
  • removes the now-unused abs import.
    The ULP bound was tightened empirically: starting from the maximum observed ULP difference across each fixture set and confirming that one less fails at least one assertion.

Measured minimum ULP bounds (test/test.js):

Fixture ULP
general (arg1/arg2/expected) 3.0
small p (p < 1e-4) 375.0
large p (p > 0.9) 45.0

Each bound is the exact minimum that passes: lowering any of the three by 1 causes at least one assertion to fail. The pre-existing "upper incomplete gamma" block (already using isAlmostSameValue with 40.0) was not touched.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

aryan7071 requested a review from a team August 28, 2026 18:06

stdlib-bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

stdlib-bot added Math Issue or pull request specific to math functionality. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. and removed Good First PR A pull request resolving a Good First Issue. labels Aug 28, 2026

stdlib-bot commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/gammaincinv $\\color{red}1647/1872$
$\\color{green}+0.00\\%$ 		$\\color{red}129/160$
$\\color{green}+0.00\\%$ 		$\\color{red}16/24$
$\\color{green}+0.00\\%$ 		$\\color{red}1647/1872$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Tests Pull requests specifically adding tests. review: 5 and removed Needs Review A pull request which needs code review. labels Aug 28, 2026
Apply batched suggestions from code review
c2ccf1a 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte merged commit 8e4bd02 into stdlib-js:develop Aug 28, 2026
28 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kgryte kgryte approved these changes

Assignees

No one assigned

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. review: 4 Tests Pull requests specifically adding tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL