FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixed non-idempotent unit tests in `JSONObjectTest` by kaiyaok2 · Pull Request #889 · stleary/JSON-java · GitHub

/ JSON-java Public

Fixed non-idempotent unit tests in JSONObjectTest - #889

Merged
stleary merged 1 commit into
stleary:masterfrom
kaiyaok2:fix_nio_tests
May 3, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Fixed non-idempotent unit tests in JSONObjectTest#889
stleary merged 1 commit into
stleary:masterfrom
kaiyaok2:fix_nio_tests

Conversation

kaiyaok2 commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

Motivation:

A couple of tests in JSONObjectTest are not idempotent and fail in the second runs in the same JVM, because they pollute states reused by themselves. Specifically, these tests first assume that SingletonEnum.getInstance() or Singleton.getInstance() are in a clean state, and then modify them. However, these instances are not cleaned up after the tests, so the repeated runs fail in the initial sanity check. It shall be good to clean the state pollution so that potential newly introduced tests do not fail in the future due to the shared state polluted by these tests.

Two non-idempotent tests are:

  • testSingletonEnumBean()
  • testSingletonBean()

Error messages for both failed tests in the second run:

java.lang.AssertionError: [someString, someInt] expected:<1> but was:<2>

Proposed Fix

Add a tearDown() method to restore the instances of SingletonEnum and Singleton to default states.

stleary commented Apr 26, 2024

Copy link
Copy Markdown
Owner

@kaiyaok2 Looks reasonable. How did you come across this issue?

kaiyaok2 commented Apr 26, 2024

Copy link
Copy Markdown
Contributor Author

@kaiyaok2 Looks reasonable. How did you come across this issue?

@stleary The issue is reported by our custom JUnit runner that supports rerunning test suite in the same JVM (different from Surefire where a new JVM is booted for each mvn test cycle)

stleary commented Apr 26, 2024

Copy link
Copy Markdown
Owner

What problem does this code solve?
Unit tests failing when executed twice in succession in the same JVM

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No

Was any code refactored in this commit?
No

Review status
APPROVED

Starting 3-day comment window

stleary merged commit 054786e into stleary:master May 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

stleary stleary approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL