restore-moditect-pom.xml restore plugin - #929
Merged
stleary merged 1 commit intoJan 7, 2025
Merged
Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
Comment thread
pom.xml
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| <plugin> |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@stleary now the plugin is duplicated
https://github.com/stleary/JSON-java/blob/master/pom.xml#L172-L219
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
Author
|
@michael-ameri Thanks for catching this. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this code solve?
Restores 20240303 behavior - module-info
Does the code still compile with Java6?
Yes
Risks
Low - this is a restore from a previous release
Changes to the API?
No
Will this require a new release?
YES - 20241224 does not contain the module
Should the documentation be updated?
No
Does it break the unit tests?
No
Was any code refactored in this commit?
No
Review status
APPROVED - by myself.
No comment window, for immediate release