FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactored large test for strict mode by marilynel · Pull Request #969 · stleary/JSON-java · GitHub

refactored large test for strict mode - #969

Merged
stleary merged 1 commit into
stleary:masterfrom
marilynel:master
Apr 18, 2025
Merged

refactored large test for strict mode#969
stleary merged 1 commit into
stleary:masterfrom
marilynel:master

Conversation

marilynel commented Apr 13, 2025
edited by stleary
Loading

Copy link
Copy Markdown
Contributor

Fixes #952

stleary commented Apr 13, 2025

Copy link
Copy Markdown
Owner

What problem does this code solve?
A few dozen unit tests were skipped during strict mode, but only 2 were actually failing. This commit refactors the unit tests into separate methods.

Does the code still compile with Java6?
Yes

Risks
Low

Changes to the API?
No

Will this require a new release?
No

Should the documentation be updated?
No

Does it break the unit tests?
No, unit tests were refactored

Was any code refactored in this commit?
Yes

Review status
APPROVED

Starting 3-day comment window

NOTE 2 tests had the exception message assert commented out, since the purpose was to confirm the exception, not the message. However, this is still tech debt that can be fixed in a later commit.

stleary merged commit 82a02d8 into stleary:master Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor JSONObjectTest jsonObjectParsingErrors()

2 participants


Back | FazBrowse Home | New Git URL