fix(api): await SMS batch status update - #288
tomatotomata wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
@tomatotomata is attempting to deploy a commit to the vernu's projects Team on Vercel. A member of the Team first needs to authorize it. |
Sorry, something went wrong.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 5c0d2743-bef7-40dd-9e2b-9b7e7e82087a You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file. Use the checkbox below for a quick retry:
Comment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
Summary
The SMS queue processor started the FCM send before awaiting the batch transition to processing. If that update failed, its rejected promise could escape the outer error handler and the batch stayed pending until the timeout task changed it to unknown.
This change awaits the status update so failures enter the existing processing error path, and removes the nested rethrow that created an unhandled rejection. A focused unit test proves the FCM send does not begin until the status update resolves and verifies the processing transition.
Closes #279.
Validation