FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(android): heartbeat body without force unwrap by wized2 · Pull Request #349 · textbee/textbee · GitHub

/ textbee Public

fix(android): heartbeat body without force unwrap - #349

Open
wized2 wants to merge 1 commit into
textbee:mainfrom
wized2:fix/hb-g
ConversationCommits (1)ChecksFiles changed
Open

fix(android): heartbeat body without force unwrap#349
wized2 wants to merge 1 commit into
textbee:mainfrom
wized2:fix/hb-g

Conversation

wized2 commented Sep 18, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

return early when response body is null.

Summary by CodeRabbit

  • Bug Fixes
    • Improved heartbeat handling when the server returns an empty response, preventing an app crash and treating the heartbeat as unsuccessful.

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

@wized2 is attempting to deploy a commit to the Nuver Labs Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai Bot commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 0baf6896-8474-49e6-876e-28e16fa52e75

📥 Commits

Reviewing files that changed from the base of the PR and between daf0d2e and 73211a2.

📒 Files selected for processing (1)
  • android/app/src/main/java/com/vernu/sms/helpers/HeartbeatHelper.kt

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.

📝 Walkthrough

Walkthrough

sendHeartbeat now returns false when the heartbeat response body is null instead of throwing a NullPointerException.

Changes

Heartbeat handling

Layer / File(s) Summary
Null response body guard
android/app/src/main/java/com/vernu/sms/helpers/HeartbeatHelper.kt		 sendHeartbeat uses response.body() ?: return false instead of a non-null assertion.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: vernu

Merge Risk: ⚪ Minimal · up to 73211

The heartbeat now avoids a crash on null responses and follows the existing failure-handling path, with no concrete merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the Android heartbeat fix. It matches the change that removes the forced unwrap from the heartbeat response body.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1 🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL