FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(android): null-safe getAvailableSimSlots when no active SIM by wized2 · Pull Request #355 · textbee/textbee · GitHub

/ textbee Public

fix(android): null-safe getAvailableSimSlots when no active SIM #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wized2 wants to merge 1 commit into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
+9 −1
Conversation 2 Commits 1 Checks 0 Files changed 1
Open

fix(android): null-safe getAvailableSimSlots when no active SIM #355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .java  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
10 changes: 9 additions & 1 deletion android/app/src/main/java/com/vernu/sms/TextbeeUtils.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ public static List<SubscriptionInfo> getAvailableSimSlots(Context context) {
}

SubscriptionManager subscriptionManager = SubscriptionManager.from(context);
return subscriptionManager.getActiveSubscriptionInfoList();
List<SubscriptionInfo> list = subscriptionManager.getActiveSubscriptionInfoList();
// API may return null when there are no active SIMs
return list != null ? list : new ArrayList<>();

}

Expand Down Expand Up @@ -138,6 +140,9 @@ public static List<SimInfoDTO> collectSimInfo(Context context) {
try {
SubscriptionManager subscriptionManager = SubscriptionManager.from(context);
List<SubscriptionInfo> subscriptionInfoList = subscriptionManager.getActiveSubscriptionInfoList();
if (subscriptionInfoList == null) {
subscriptionInfoList = new ArrayList<>();
}

if (subscriptionInfoList == null) {
Log.d(TAG, "No active subscriptions found");
Expand Down Expand Up @@ -383,6 +388,9 @@ public static boolean isValidSubscriptionId(Context context, int subscriptionId)
try {
SubscriptionManager subscriptionManager = SubscriptionManager.from(context);
List<SubscriptionInfo> subscriptionInfoList = subscriptionManager.getActiveSubscriptionInfoList();
if (subscriptionInfoList == null) {
subscriptionInfoList = new ArrayList<>();
}

if (subscriptionInfoList == null) {
return false;
Expand Down
Back | FazBrowse Home | New Git URL