tests: improve subtest cleanup - #2994
Merged
jku merged 1 commit intoAug 25, 2026
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Signed-off-by: aryadeepta <aryadeeptade@gmail.com>
Copy link
Copy Markdown
Member
|
test-with-sslib-main failure on CI is unrelated |
Sorry, something went wrong.
jku
approved these changes
Aug 25, 2026
jku
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Yeah looks about as good as we can get without switching to pytest.
Thanks for the patch.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Updates run_sub_tests_with_dataset to call teardown_subtest() in a
finally block when it is defined. This ensures per-subtest cleanup runs
even when a subtest fails.
Removes the now-redundant try/finally cleanup blocks from the affected
updater tests and adds regression coverage for cleanup after a failing
subtest.
Testing:
Fixes #1719