fix: make metadata classes hashable by fixing __hash__ implementations - #3002
Closed
mmustafasenoglu wants to merge 1 commit into
Closed
fix: make metadata classes hashable by fixing __hash__ implementations#3002mmustafasenoglu wants to merge 1 commit into
mmustafasenoglu wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Fixes TypeError: unhashable type: 'dict' for 8 metadata classes: - Signed, Root, MetaFile, Timestamp, Snapshot - Delegations, TargetFile, Targets, Metadata Following the pattern from #2973 (Role/DelegatedRole): - Convert dicts to tuples of sorted items for hashability - Exclude unrecognized_fields (arbitrary nested JSON) - Preserve Python data model: equal objects produce equal hashes Signed-off-by: Mustafa Senoglu <mmustafasenoglu0@gmail.com>
Copy link
Copy Markdown
Member
|
Thanks but I'm closing for #2995 that is closer to complete and earlier.
this is a bit spammy, maybe disable the automated reviews if you don't have credits. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TypeError: unhashable type: 'dict' for 8 metadata classes:
Following the pattern from #2973 (Role/DelegatedRole):
All existing tests pass. Ready for review.