find: use GNU wording "unknown predicate" for unrecognized args - #724
Draft
sylvestre wants to merge 1 commit into
Draft
find: use GNU wording "unknown predicate" for unrecognized args#724sylvestre wants to merge 1 commit into
sylvestre wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
GNU find rejects an unrecognized predicate with "find: unknown predicate '<arg>'", but we printed "find: Unrecognized flag: '<arg>'". Match GNU so the tests/find/refuse-noop GNU test (and others hitting the same path) pass. Add an integration test covering -noop and ---noop.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #724 +/- ##
==========================================
+ Coverage 91.85% 91.91% +0.05%
==========================================
Files 35 35
Lines 7149 7202 +53
Branches 375 380 +5
==========================================
+ Hits 6567 6620 +53
Misses 437 437
Partials 145 145 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GNU find rejects an unrecognized predicate with
"find: unknown predicate ''", but we printed
"find: Unrecognized flag: ''". Match GNU so the tests/find/refuse-noop GNU test (and others hitting the same path) pass. Add an integration test covering -noop and ---noop.