FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

find: -printf: advance past a full char in advance_one to avoid a multibyte panic by leeewee · Pull Request #731 · uutils/findutils · GitHub

/ findutils Public

find: -printf: advance past a full char in advance_one to avoid a multibyte panic - #731

Open
leeewee wants to merge 1 commit into
uutils:mainfrom
leeewee:find-fix-printf-advance-multibyte
ConversationCommits (1)ChecksFiles changed
Open

find: -printf: advance past a full char in advance_one to avoid a multibyte panic#731
leeewee wants to merge 1 commit into
uutils:mainfrom
leeewee:find-fix-printf-advance-multibyte

Conversation

leeewee commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Fixes #730

advance_one read a full char via front() but then dropped it by slicing one byte (&self.string[1..]). When that char is multibyte (e.g. € after a % conversion, a \ escape, or a %A/%C/%T time directive), byte index 1 is not a char boundary, so the slice panicked:

$ mkdir d; touch d/a
$ find d -printf '%€\n'
thread 'main' panicked at src/find/matchers/printf.rs:152:35:
byte index 1 is not a char boundary; it is inside '€' (bytes 0..3) of `€`
$ echo $?
101

(also \€ and %A€ / %C€ / %T€)

This advances by the leading char's UTF-8 length (c.len_utf8()) instead of a fixed 1, so a multibyte char routes through the normal handling instead of aborting — the same multibyte-aware approach #723 applied to peek. Unrecognized escapes / invalid time specifiers keep their existing behavior (a multibyte char now behaves exactly like its ASCII equivalent, e.g. \€ like \q).

Added a regression test (test_parse_multibyte_char_after_directive).

codecov Bot commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.89%. Comparing base (3f9926c) to head (7815cf9).
⚠️ Report is 40 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #731   +/-   ##
=======================================
  Coverage   91.88%   91.89%           
=======================================
  Files          35       35           
  Lines        7233     7240    +7     
  Branches      376      376           
=======================================
+ Hits         6646     6653    +7     
  Misses        444      444           
  Partials      143      143

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codspeed-hq Bot commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 20 untouched benchmarks

Comparing leeewee:find-fix-printf-advance-multibyte (7815cf9) with main (3f9926c)

leeewee force-pushed the find-fix-printf-advance-multibyte branch from 94d6c7a to 13da7cc Compare June 12, 2026 05:54

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

Commit c211220 has test result changes:

bfs testsuite:

Test results comparison:
  Current:   TOTAL: 314 / PASSED: 267 / FAILED: 41 / SKIPPED: 6
  Reference: TOTAL: 314 / PASSED: 267 / FAILED: 41 / SKIPPED: 6

New test failures (2):
  - gnu/files0_from_ok
  - gnu/ok_flush

Test improvements (2):
  + gnu/okdir_path_empty
  + gnu/okdir_path_relative

sylvestre commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

On windows:

failures:

---- find_printf stdout ----
bin: "D:\\a\\findutils\\findutils\\target\\debug\\find.exe"
run: D:\a\findutils\findutils\target\debug\find.exe .\test_data\simple -sorted -printf %f %d %h %H %p %P %y

bin: "D:\\a\\findutils\\findutils\\target\\debug\\find.exe"
run: D:\a\findutils\findutils\target\debug\find.exe a -printf %A+

thread 'find_printf' (8780) panicked at tests\test_find.rs:486:5:
Output did not match expected timestamp format
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

leeewee commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

On windows:

failures:

---- find_printf stdout ----
bin: "D:\\a\\findutils\\findutils\\target\\debug\\find.exe"
run: D:\a\findutils\findutils\target\debug\find.exe .\test_data\simple -sorted -printf %f %d %h %H %p %P %y

bin: "D:\\a\\findutils\\findutils\\target\\debug\\find.exe"
run: D:\a\findutils\findutils\target\debug\find.exe a -printf %A+

thread 'find_printf' (8780) panicked at tests\test_find.rs:486:5:
Output did not match expected timestamp format
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The find_printf failure is unrelated to this PR — the change here is only in advance_one, a no-op for ASCII, so it can't affect %A+. But digging in, it's a real pre-existing bug: %A+/%C+/%T+ use chrono %.f, which drops the fraction when it isn't full-precision, so e.g. a whole-second timestamp prints …:200 instead of GNU's …:20.0000000000. That's what makes the test flaky on Windows (coarse file times).

leeewee commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

I opened #757 to fix the underlying issue — the %A+ fraction wasn't fixed-width, which is what made this test flaky on Windows.

sylvestre commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

"This branch cannot be rebased due to conflicts"
could you please rebase it? thanks

find: -printf: advance past a full char in advance_one to avoid a panic
7815cf9 
advance_one read a full `char` via front() but then dropped it by slicing one
byte (`&self.string[1..]`). When that char is multibyte (e.g. a `€` after a `%`
conversion, a `\` escape, or a `%A`/`%C`/`%T` time directive), byte index 1 is
not a char boundary and the slice panics. Advance by the char's UTF-8 length so
multibyte input routes through the normal handling instead of aborting.
leeewee force-pushed the find-fix-printf-advance-multibyte branch from c211220 to 7815cf9 Compare July 27, 2026 04:45

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

Commit 7815cf9 has test result changes:

bfs testsuite:

Test results comparison:
  Current:   TOTAL: 315 / PASSED: 267 / FAILED: 42 / SKIPPED: 6
  Reference: TOTAL: 314 / PASSED: 267 / FAILED: 41 / SKIPPED: 6

Changes from main branch:
  TOTAL: +1
  PASSED: +0
  FAILED: +1

New test failures (1):
  - gnu/files0_from_ok

leeewee commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto the latest main.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

find: -printf: advance_one still panics on a multibyte char (after %, \, or a time directive)

2 participants

Back | FazBrowse Home | New Git URL