Pull request overview

Adds support for explicitly disabling Vite+ Node.js version management via the action input node-version: off, aimed at users who manage Node.js through other tooling.

Changes:

• Update main action flow to treat node-version: off as a request to run vp env off.
• Update action.yml input documentation to mention the off option.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3376754c01

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

action.yml:25

• The node-version input description still claims it "Defaults to Node.js latest LTS version", but there is no default: for this input and the action only manages Node when node-version (or node-version-file) is provided. Since this PR updates the description, it should accurately document the three states: unset (no Node management unless node-version-file is set), a version (runs vp env use), and off (runs vp env off).

    description: "Node.js version to install via `vp env use`. Defaults to Node.js latest LTS version. Pass `off` to disable."

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

action.yml:25

• The node-version input description still claims it defaults to the latest LTS, but there is no default: for this input and the action only runs vp env use when a value is provided. This is misleading, especially now that off is a supported explicit value. Reword to document the three states: unset (no Node management), version (env use), and off (env off).

    description: "Node.js version to install via `vp env use`. Defaults to Node.js latest LTS version. Pass `off` to disable."

src/index.ts:38

• "off" is now a reserved sentinel value for the node-version input, but this logic also triggers when nodeVersion comes from node-version-file. If a version file accidentally contains off, the action will run vp env off (or silently skip Node setup) instead of failing fast, which can mask a bad version file. Gate the vp env off branch on the explicit node-version input, and consider throwing if node-version-file resolves to the reserved value.

    info(`Setting up Node.js ${nodeVersion} via vp env use...`);
    await exec("vp", ["env", "use", nodeVersion]);
  } else if (nodeVersion === "off") {
    info("Disabling Node.js version management with vp env off...");
    await exec("vp", ["env", "off"]);

Pull request overview

Copilot reviewed 22 out of 25 changed files in this pull request and generated no new comments.

action.yml:32

• The node-version input description currently implies the action will run vp env use by default ("Defaults to Node.js latest LTS"), but src/index.ts only runs vp env use when node-version/node-version-file is provided. This makes the input docs misleading, especially now that node-manager controls whether Vite+'s own manager is used. Consider rewording node-version to describe the conditional behavior (and optionally mention how node-manager interacts).

  node-manager:
    description: "Control Vite+'s Node.js version manager. When unset, the Vite+ installer decides (enabled on CI). Set to `false` to keep the Node.js already on the runner (e.g. from actions/setup-node or the runner image): shim creation is skipped and vp commands prefer the system Node.js. Set to `true` to force-enable the managed Node.js. Cannot be `false` together with node-version or node-version-file."
    required: false

src/inputs.ts:13

• The PR title/description calls out disabling Node management via node-version: off, but the implementation introduces a separate node-manager input and does not recognize node-version=off (no matches in the codebase). This mismatch may confuse users following the PR title. Consider either supporting node-version: off as an alias for node-manager: false, or updating the PR title/docs to consistently refer to node-manager: false.

  const nodeVersion = getInput("node-version") || undefined;
  const nodeVersionFile = getInput("node-version-file") || undefined;
  const nodeManager = parseNodeManager(getInput("node-manager"));
  if (nodeManager === false && (nodeVersion || nodeVersionFile)) {
    throw new Error(

README.md:63

• This section documents opting out via node-manager: false, while the PR title mentions node-version: off. If node-version: off is no longer the intended UX, consider updating the PR title (and any related docs) to avoid conflicting guidance; otherwise, document/support the node-version: off alias explicitly.

### Keep the Runner's Node.js

The Vite+ installer enables its own Node.js version manager on CI. When
Node.js is managed elsewhere (`actions/setup-node`, Flox, mise, or the runner
image), disable it so `vp` and its shims use that Node.js:

Pull request overview

Copilot reviewed 22 out of 25 changed files in this pull request and generated no new comments.

README.md:71

• This example uses voidzero-dev/setup-vp@v1.16.1, but node-manager is introduced by this PR; users following the docs on v1.16.1 won't have that input available. Update the tag in this snippet to a version that includes node-manager (or use @v1).

  - uses: voidzero-dev/setup-vp@v1.16.1

gitlab/setup-vp.yml:18

• node-manager is wired through this template, but the default setup-ref still points at v1.16.1. That ref determines which bootstrap.sh/runtime bundle is downloaded; with the older default, node-manager won't be applied unless users also override setup-ref. Bump the default setup-ref to the release that includes this feature.

    node-manager:
      description: 'Control Vite+''s Node.js version manager. This is a string input: empty (default) lets the Vite+ installer decide (enabled on CI); "false" keeps the runner image''s Node.js (skips shim creation and makes vp commands prefer the system Node.js); "true" force-enables the managed Node.js.'
      default: ""

azure/setup-vp.yml:28

• This template adds the nodeManager parameter and exports SETUP_VP_NODE_MANAGER, but setupRef still defaults to v1.16.1 (the ref used to download azure/bootstrap.* and dist/azure/index.mjs). With that older default, nodeManager won't take effect unless users also bump setupRef. Update the default to the version that contains this feature.

  - name: nodeManager
    type: string
    default: ""