ci: re-run bundle rebuild when Renovate pushes to a labeled PR - #122
Merged
fengmk2 merged 1 commit intoAug 6, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The rebuild-bundle workflow only fired on the labeled event, so when the one rebuild attempt failed or Renovate rebased the PR afterwards, dist/ stayed stale and the "Verify dist is up to date" check kept failing (seen on #119). Trigger on synchronize as well, gated on the label being present. The run triggered by our own dist/ push finds no diff and exits without pushing, so it cannot loop.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions workflow that rebuilds and pushes dist/ so Renovate PRs automatically re-run the bundle rebuild when they get rebased/updated (not just when initially labeled), preventing “Verify dist is up to date” from staying red after a transient rebuild failure.
Changes:
- Expand the pull_request trigger to include synchronize in addition to labeled.
- Gate the job on presence of the needs-bundle-rebuild label via contains(github.event.pull_request.labels.*.name, ...) so the workflow only runs for labeled PRs across both event types.
- Update the workflow header comments to document the new behavior and non-looping rationale.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Merged
fengmk2
added a commit
that referenced
this pull request
Aug 6, 2026
Bump the version to v1.17.0 in package.json, the README examples, and the setup-ref / setupRef defaults in the GitLab and Azure templates. Changes since v1.16.1: - feat: support disabling Vite+'s Node.js management with node-manager: false (#115) - fix: retry sfw vp install when sfw misreports vp as not found on Windows (#120) - chore(deps): update vite-plus to v0.2.8 (#119) - ci: re-run bundle rebuild when Renovate pushes to a labeled PR (#122) - chore: align Renovate release age for the whole vite-plus group (#121) After merge, tag the merge commit as v1.17.0 and push the tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rebuild-bundle workflow only fired on the labeled event, so a failed rebuild never retried: the label is added once at PR creation, and later Renovate rebases never re-triggered it. On #119 the first rebuild crashed during pnpm install (vite-plus-core 0.2.7 missing its rolldown linux binding), and after Renovate rebased to 0.2.8 the stale dist/ kept failing the "Verify dist is up to date" check until the label was manually re-added.
Changes: