FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(workspace): support dot-relative workspace patterns by liangmiQwQ · Pull Request #547 · voidzero-dev/vite-task · GitHub

fix(workspace): support dot-relative workspace patterns - #547

Merged
wan9chi merged 5 commits into
voidzero-dev:mainfrom
liangmiQwQ:liang/codex/fix-workspace-dot-slash
Jul 20, 2026
Merged

fix(workspace): support dot-relative workspace patterns#547
wan9chi merged 5 commits into
voidzero-dev:mainfrom
liangmiQwQ:liang/codex/fix-workspace-dot-slash

Conversation

liangmiQwQ commented Jul 19, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Closes voidzero-dev/vite-plus#2201

Motivation

npm accepts workspace patterns that start with ./, but Vite Task passed those patterns directly to the glob walker and failed to discover matching packages.

This PR strips the current-directory prefix before matching while preserving optional negation. The existing npm workspace graph test now covers the reported ./packages/* and ./apps/* forms.

🤖 Generated with Codex

Co-authored-by: GPT-5 Codex <codex@openai.com>
liangmiQwQ force-pushed the liang/codex/fix-workspace-dot-slash branch from c990385 to fd4dcb2 Compare July 19, 2026 06:27
Co-authored-by: GPT-5 Codex <codex@openai.com>
liangmiQwQ marked this pull request as ready for review July 19, 2026 06:41

Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: fcac813ae1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vite_workspace/src/lib.rs Outdated
Comment thread crates/vite_workspace/src/lib.rs Outdated
liangmiQwQ marked this pull request as draft July 20, 2026 09:35
liangmiQwQ force-pushed the liang/codex/fix-workspace-dot-slash branch from 79e1587 to fcac813 Compare July 20, 2026 09:37

Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: ff981bd8eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

liangmiQwQ marked this pull request as ready for review July 20, 2026 09:59
liangmiQwQ requested a review from wan9chi July 20, 2026 09:59

wan9chi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

Co-authored-by: GPT-5 Codex <codex@openai.com>
wan9chi merged commit 48240fb into voidzero-dev:main Jul 20, 2026
15 checks passed
liangmiQwQ deleted the liang/codex/fix-workspace-dot-slash branch July 20, 2026 13:24
wan9chi added a commit to voidzero-dev/vite-plus that referenced this pull request Jul 22, 2026
Bumps the vite-task git-dependency crates (`fspy`, `pty_terminal_test`,
`pty_terminal_test_client`, `snapshot_test`, `vite_path`,
`vite_powershell`, `vite_str`, `vite_task`, `vite_workspace`) from
`4003f65` to `85d4e73`.

## Changelog

All three new entries are internal bug fixes with no user-facing
CLI/config changes, so no docs updates are needed:

- Task cache now supports much larger automatically tracked input sets
without hitting wincode's default 4 MiB sequence preallocation limit
([#554](voidzero-dev/vite-task#554))
- npm workspace patterns beginning with `./` now discover matching
packages correctly
([#547](voidzero-dev/vite-task#547))
- Failures while forwarding output from a started task process no longer
incorrectly report that the process failed to spawn
([#506](voidzero-dev/vite-task#506))

Full diff:
``https://github.com/voidzero-dev/vite-task/compare/4003f65a3e5e3d957ff81b157e85e6ee41cc59fc...85d4e734c64c96c2ce60e734b3e202b5add53696#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4ed``

## Verification

- `cargo check --workspace` — clean (no breaking changes; the PTY
snapshot runner compiles against the new vite-task crates without
changes)
- `cargo test` across the vite-plus crates (`vite_command`,
`vite_error`, `vite_install`, `vite_js_runtime`, `vite_migration`,
`vite_shared`, `vite_static_config`, `vite-plus-cli`, `vite_global_cli`)
— all pass
- PTY snapshot suite (global flavor): the task-runner/cache output cases
that the bump could affect (`command_run_help`, `command_cache_*`,
`shim_recursive_npm_run`) pass unchanged. The remaining failures in this
sandbox are environmental (missing bootstrapped JS CLI `dist/bin.js`,
and npm-registry TLS blocked by the proxy) and are left to CI, which
bootstraps the CLI and registry bridge.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---
_Generated by [Claude
Code](https://claude.ai/code/session_01LGJPQK1jAPZVtj4eCuWMPm)_

Co-authored-by: Claude <noreply@anthropic.com>
wan9chi added a commit to voidzero-dev/vite-plus that referenced this pull request Jul 23, 2026
…2217)

Release vite-plus v0.2.6: Stable type-aware linting and a refreshed
toolchain.

This release moves Vite+'s type-aware linting to the [stable tsgolint 7
engine](https://oxc.rs/blog/2026-07-22-type-aware-linting-stable),
refreshes the bundled build and formatting tools, strengthens `vp run`
caching and workspace discovery, and removes the redundant `vp build`
startup banner.

### Highlights

- Move bundled type-aware linting to stable tsgolint 7 with 59 of 61
typescript-eslint type-aware rules, and update Vite `8.1.4` -> `8.1.5`,
Rolldown `1.1.5` -> `1.2.0`, tsdown `0.22.7` -> `0.22.13`, Oxlint
`1.73.0` -> `1.75.0`, oxlint-tsgolint `0.24.0` -> `7.0.2001`, and Oxfmt
`0.58.0` -> `0.60.0`
([#2214](#2214)), by
@voidzero-guard[bot]
- Improve `vp run` reliability by caching much larger automatically
tracked input sets, discovering npm workspaces whose patterns start with
`./`, and reporting output-forwarding failures accurately
([vite-task#554](voidzero-dev/vite-task#554),
[vite-task#547](voidzero-dev/vite-task#547),
[vite-task#552](voidzero-dev/vite-task#552),
[#2215](#2215)), by
@wan9chi and @liangmiQwQ
- Remove the redundant Vite startup banner from `vp build` output and
fail fast when upstream Vite changes invalidate Vite+ branding patches
([#2200](#2200),
[#2205](#2205)), by
@liangmiQwQ

### Refactor

- Deduplicate package-manager version gates in migration catalog
handling ([#2216](#2216)),
by @jong-kyung
- Unify static and generated CLI help under one document model and
renderer ([#2211](#2211)),
by @jong-kyung
- Reuse shared subprocess exit-status handling across global CLI command
paths ([#2196](#2196)), by
@jong-kyung

### Docs

- Fix broken documentation anchors and add Migration Rules to the
Migrate sidebar
([#2203](#2203)), by
@charpeni

### Chore

- Stabilize `vp create` build-approval snapshots by removing package-age
timing from those fixtures
([#2224](#2224)), by
@wan9chi
- Remove the temporary release workflow dispatch used for the previous
release ([#2193](#2193)),
by @wan9chi
- Share package-manager fixtures across CLI tests
([#2197](#2197)), by
@jong-kyung
- Remove stale raw Oxlint and Oxfmt development dependencies that
bypassed repository editor configuration
([#2187](#2187)), by
@liangmiQwQ

### Bundled Versions

| Tool | Version | Source |
| --------------- | ------- |
-----------------------------------------------------------------------
|
| vite | `8.1.5` |
[`5e7fe12`](vitejs/vite@5e7fe12)
|
| rolldown | `1.2.0` |
[`03e1e34`](rolldown/rolldown@03e1e34)
|
| tsdown | `0.22.13` | [npm](https://npmx.dev/package/tsdown/v/0.22.13)
|
| vitest | `4.1.10` | [npm](https://npmx.dev/package/vitest/v/4.1.10) |
| oxlint | `1.75.0` | [npm](https://npmx.dev/package/oxlint/v/1.75.0) |
| oxlint-tsgolint | `7.0.2001` |
[npm](https://npmx.dev/package/oxlint-tsgolint/v/7.0.2001) |
| oxfmt | `0.60.0` | [npm](https://npmx.dev/package/oxfmt/v/0.60.0) |

### Upgrade

```bash
vp upgrade
```

### New Contributors

Welcome @charpeni.

**Full Changelog**:
v0.2.5...v0.2.6

---

Merging this PR will trigger the release workflow.

---------

Co-authored-by: voidzero-guard[bot] <278573678+voidzero-guard[bot]@users.noreply.github.com>
Co-authored-by: wan9chi <dk4rest@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Monorepo packages detection logic does not match npm

2 participants


Back | FazBrowse Home | New Git URL