fix: add "devServer.server.type" to "useHttps" judgement by backrunner · Pull Request #7222 · vuejs/vue-cli · GitHub

What kind of change does this PR introduce? (check at least one)

Bugfix
Feature
Code style update
Refactor
Docs
Underlying tools
Other, please describe:

Does this PR introduce a breaking change? (check one)

Yes
No

Other information:

In the recent merged Pull Request #7202 which authored by me, the fixed judgement expression is not perfect, it should also consider the devServer.server.type because it can be an object.

This patch add another judgement expression to cover this case, if user set devServer.server.type to https or spdy, the protocol will be https.

With this fix https for the application seems to work fine, however it fails to connect to HMR server:

module.exports = defineConfig({
  devServer: {
    server: {
      type: 'https',
      options: {
        key: fs.readFileSync('...'),
        cert: fs.readFileSync('...'),
      },
    },
  },

iirc the following config worked in vue cli 4/webpack 4

  devServer: {
    https: {
      key: fs.readFileSync('...'),
      cert: fs.readFileSync('...'),
    },
  },

With this fix https for the application seems to work fine, however it fails to connect to HMR server:

module.exports = defineConfig({
  devServer: {
    server: {
      type: 'https',
      options: {
        key: fs.readFileSync('...'),
        cert: fs.readFileSync('...'),
      },
    },
  },

iirc the following config worked in vue cli 4/webpack 4

  devServer: {
    https: {
      key: fs.readFileSync('...'),
      cert: fs.readFileSync('...'),
    },
  },

Your case is similar to #7160, if NODE_ENV is not production, @vue/cli-service always prefer using the lan IP as webSocketURL. I think that might not work properly in some scenarios. You can try to set devServer.client.webSocketURL to auto://localhost:[YOUR_SERVER_PORT]/ws and set devServer.allowedHosts to all if you're running the dev server at local.

Thanks @backrunner
Following config works fine for me

  devServer: {
    server: {
      type: 'https',
      options: {
        key: fs.readFileSync('...'),
        cert: fs.readFileSync('...'),
      },
    },
    client: {
      webSocketURL: 'auto://localhost:8081/ws',
    },
    allowedHosts: 'all',
  },

 devServer: {
    server: {
      type: "https",
      // options: {
      //   key: fs.readFileSync("/Users/li/server.key"),
      //   cert: fs.readFileSync("/Users/li/server.crt")
      // }
    },
    client: {
      webSocketURL: "https://localhost:4003/"
    },
    allowedHosts: ["all"],
    overlay: {
      warnings: false,
      errors: false
    },
    headers: {
      "Access-Control-Allow-Origin": "*"
    },
    // host: "192.168.1.8",
    port: 4003, // 端口号
    // https: true,
    // open: false, //配置自动启动浏览器
    hot: true, // 热更新
    hotOnly: true,
    disableHostCheck: true,
    proxy: {
      "/api": {
        target: "https://yanshou4.xxx.com/", // 测试环境
        changeOrigin: true,
        pathRewrite: {
          "^/": "/"
        }
      }
    }
  }

增加了上述配置后，报错了

fix: add devServer.server.type to useHttps judgement

9027e4c

backrunner mentioned this pull request Jul 7, 2022

HTTPS not working as expected #7227

Open

haoqunjiang approved these changes Jul 7, 2022

View reviewed changes

haoqunjiang merged commit 0260e4d into vuejs:dev Jul 7, 2022

finalcut mentioned this pull request Sep 22, 2022

Bump ejs and @vue/cli-service finalcut/vue-lootly#36

Merged

Silverium mentioned this pull request Oct 28, 2022

Bump jsdom and @vue/cli-plugin-unit-jest Silverium/popper-vue#39

Open

xiaopohou mentioned this pull request Dec 30, 2022

Bump json5, @vue/cli-plugin-babel, @vue/cli-plugin-eslint, @vue/cli-service and sass-loader in /House-Map.UI liguobao/HouseSearch#151

Closed

Silverium mentioned this pull request Jan 3, 2023

Bump json5, @vue/cli-plugin-unit-jest, @vue/cli-service, rollup-plugin-vue and vue-jest Silverium/popper-vue#44

Closed

Silverium mentioned this pull request Aug 26, 2023

Bump tough-cookie, @vue/cli-plugin-babel, @vue/cli-plugin-typescript, @vue/cli-plugin-unit-jest, @vue/cli-service, jsdom, node-sass and less Silverium/popper-vue#45

Open

Silverium mentioned this pull request Jun 12, 2024

Bump braces, @vue/cli-plugin-babel, @vue/cli-plugin-typescript, @vue/cli-plugin-unit-jest, @vue/cli-service and jest Silverium/popper-vue#55

Open

fix: add "devServer.server.type" to "useHttps" judgement by backrunner · Pull Request #7222 · vuejs/vue-cli · GitHub

Uh oh!

fix: add "devServer.server.type" to "useHttps" judgement - #7222

fix: add "devServer.server.type" to "useHttps" judgement#7222
haoqunjiang merged 1 commit into
vuejs:devfrom
backrunner:backrunner-patch-0705

backrunner commented Jul 5, 2022

Uh oh!

jacekkarczmarczyk commented Jul 7, 2022 •
edited
Loading

Uh oh!

Uh oh!

backrunner commented Jul 7, 2022 •
edited
Loading

Uh oh!

Uh oh!

jacekkarczmarczyk commented Jul 8, 2022

Uh oh!

lyanerzhang commented Aug 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: add "devServer.server.type" to "useHttps" judgement by backrunner · Pull Request #7222 · vuejs/vue-cli · GitHub

Uh oh!

fix: add "devServer.server.type" to "useHttps" judgement - #7222

fix: add "devServer.server.type" to "useHttps" judgement#7222haoqunjiang merged 1 commit intovuejs:devvuejs/vue-cli:devfrom backrunner:backrunner-patch-0705backrunner/vue-cli:backrunner-patch-0705Copy head branch name to clipboard

Conversation

backrunner commented Jul 5, 2022

Uh oh!

jacekkarczmarczyk commented Jul 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

backrunner commented Jul 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jacekkarczmarczyk commented Jul 8, 2022

Uh oh!

lyanerzhang commented Aug 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: add "devServer.server.type" to "useHttps" judgement#7222
haoqunjiang merged 1 commit into
vuejs:devfrom
backrunner:backrunner-patch-0705

jacekkarczmarczyk commented Jul 7, 2022 •
edited
Loading

backrunner commented Jul 7, 2022 •
edited
Loading