fix: use RuntimeKey instead of Runtime for export generation - #20346
fix: use RuntimeKey instead of Runtime for export generation#20346alexander-akait merged 7 commits into
Conversation
Sorry, something went wrong.
🦋 Changeset detectedLatest commit: 938944a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sorry, something went wrong.
|
This PR is packaged and the instant preview is available (3a73621). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@3a73621
yarn add -D webpack@https://pkg.pr.new/webpack@3a73621
pnpm add -D webpack@https://pkg.pr.new/webpack@3a73621 |
Sorry, something went wrong.
CodSpeed Performance ReportMerging this PR will improve performance by 27.82%Comparing issue-20332 (938944a) with main (bf00b73) Summary⚡ 1 improved benchmark Performance Changes
|
Sorry, something went wrong.
| * @property {Map<RuntimeSpec, Record<string, string>>=} exportsFinalNameByRuntime | ||
| * @property {Map<RuntimeSpec, string>=} exportsSourceByRuntime | ||
| * @property {Map<string, Record<string, string>>=} exportsFinalNameByRuntime | ||
| * @property {Map<string, string>=} exportsSourceByRuntime |
There was a problem hiding this comment.
Is the expected change?
Sorry, something went wrong.
There was a problem hiding this comment.
Yeah, getRuntimeKey return string.
Sorry, something went wrong.
alexander-akait
left a comment
There was a problem hiding this comment.
Looks good
Sorry, something went wrong.
|
Added the test. But we need to merge #20350 first to fix an issue in the ESM test runner. |
Sorry, something went wrong.
Summary
Fixes #20332.
What kind of change does this PR introduce?
In RuntimeSpecSet, we deduplicate runtimes by RuntimeKey, so no extra runtimes are stored here when it have same RuntimeKey.
However, when a concatenated module is generated in different chunks that share the same runtime value (equal in value but not the same reference), we still need to generate the export statement. To ensure it, we should use RuntimeKey to make sure that no runtimes are missing.
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No