FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(decisions): stop crediting AI agents as decision-record deciders by ss-o · Pull Request #577 · z-shell/.github · GitHub

fix(decisions): stop crediting AI agents as decision-record deciders - #577

Merged
ss-o merged 1 commit into
mainfrom
code/decision-deciders-no-agents
Aug 30, 2026
Merged

fix(decisions): stop crediting AI agents as decision-record deciders#577
ss-o merged 1 commit into
mainfrom
code/decision-deciders-no-agents

Conversation

ss-o commented Aug 30, 2026

Copy link
Copy Markdown
Member

Summary

Four accepted decision records credited an automation identity in Deciders:

ADR Was Now
0004 ss-o, Gemini CLI ss-o
0005 ss-o, Claude Code ss-o
0006 ss-o, Claude Code ss-o
0007 ss-o, Claude Code ss-o

This contradicts two existing rules. Organization policy bans crediting a bot or AI agent as a co-author, enforced for commit trailers by the commit-msg hook in scripts/git-hooks. And runbooks/adr.md reserves decision authority for a maintainer: an agent may draft a record, it never decides one.

In each case ss-o was the actual decider, so the agent is dropped rather than the record rewritten. No decision content changed.

This was surfaced by the decision index added in #576 — putting all 21 records in one table made the four outliers visible immediately, which is the kind of drift the index exists to catch.

Enforcement

Prose alone would drift back, so scripts/decision-records.py now rejects an automation identity in Deciders. This is the decision-record half of the rule the commit-msg hook already enforces for commit trailers, matching [bot] suffixes and known agent product names. It runs in CI with the rest of the record contract.

Verified the check flags exactly the four known records and nothing else before correcting them, so the pattern is not over-broad. test_allows_human_deciders pins that a multi-human Deciders value stays valid.

Pre-existing defects also fixed

Both were latent because the CI lint job only scans files changed by a pull request, so a finding in an untouched file never surfaces until something else edits that file.

Worth noting: a whole-repository trunk check --all reports roughly 70 further findings across 288 files, all in files untouched by this change. That backlog is out of scope here and would need its own cleanup pass.

Verification

python3 -m unittest scripts/test_decision_records.py             17 tests, OK
python3 -m unittest scripts/test_validate_agent_policy.py        84 tests, OK
python3 -m unittest scripts/test_validate_zsh_standard_policy.py 99 tests, OK
python3 scripts/validate-zsh-standard-policy.py                  passed
python3 scripts/validate-agent-policy.py                         passed
python3 scripts/decision-records.py --check                      passed
trunk check --no-fix                                             27 files, no issues

Four accepted records listed an automation identity in `Deciders`:

- 0004 "ss-o, Gemini CLI"
- 0005 "ss-o, Claude Code"
- 0006 "ss-o, Claude Code"
- 0007 "ss-o, Claude Code"

That contradicts organization policy, which bans crediting a bot or AI agent
as a co-author, and runbooks/adr.md, which reserves decision authority for a
maintainer. An agent may draft a record; it never decides one. In each case
ss-o was the actual decider, so the agent is dropped rather than the record
rewritten.

Prose alone would drift back, so scripts/decision-records.py now rejects an
automation identity in `Deciders`. This is the decision-record half of the
rule the commit-msg hook already enforces for commit trailers. The pattern
matches `[bot]` suffixes and known agent product names, and the check runs in
CI with the rest of the record contract.

Also fixes a pre-existing black formatting failure in
scripts/test_validate_zsh_standard_policy.py, and a pre-existing prettier
emphasis-style drift in ADR 0006. Neither was caught before because the CI
lint job only scans files changed by a pull request, so a latent finding in an
untouched file never surfaces until something else edits that file.
ss-o requested a review from a team as a code owner August 30, 2026 06:09
ss-o merged commit d203503 into main Aug 30, 2026
7 checks passed
ss-o deleted the code/decision-deciders-no-agents branch August 30, 2026 06:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL