fix Future exception never retrieved in create_connection - #590
Open
jensbjorgensen wants to merge 1 commit into
Open
fix Future exception never retrieved in create_connection#590jensbjorgensen wants to merge 1 commit into
jensbjorgensen wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
fantix
reviewed
Aug 15, 2024
fantix
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This makes sense! Though a unit test is preferred.
Sorry, something went wrong.
Comment thread
uvloop/loop.pyx
| except asyncio.CancelledError as exc: | ||
| for fut in fs: | ||
| fut.cancel() | ||
| raise exc from None |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Why dropping the original context here, instead of just raise?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also have observed that when I use asyncio.wait_for(...) around loop.create_connection in the timeout case I end up getting this logged to stdout(err?):
The code in this commit fixes this.