really drop python<=3.7 support - #608
Open
kloczek wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Filter all code over `pyupgrade --py38-plus`. Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
"requires-python = '>=3.8.0'" in pyproject.toml is enough. Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
fantix
approved these changes
Aug 15, 2024
fantix
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for the PR! I feel neutral about most of the changes here, but still approving.
Sorry, something went wrong.
Comment thread
setup.py
Comment on lines
-3
to
-6
| vi = sys.version_info | ||
| if vi < (3, 8): | ||
| raise RuntimeError('uvloop requires Python 3.8 or greater') | ||
|
|
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
"requires-python = '>=3.8.0'" in pyproject.toml is enough.
I'd keep this extra check. For people who uses Python < 3.8, they may also have a pip around year 2016 or earlier, which doesn't honor requires-python.
Sorry, something went wrong.
Comment thread
tests/test_pipes.py
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
unused import io now
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter all code over pyupgrade --py38-plus.