Optimize context.run by making custom C Functions for it - #722
Open
Vizonex wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Seems that 3.10 macos rounding bug is still jumping in. Do I need to fix that or is this Pull-Request Excusable from that issue? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This looks very similar to my PR that I did a year ago ;) Except that I let Cython to generate code for calling function objects and to handle try-finally block. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found an optimization recently while brainstorming ways to make contextvars faster.
I have left some details about this in compat.h which is where I put these functions for winloop also
The reason this is faster is because we no longer need to lookup the run method before making any calls to the functions being handled and when we have many handles doing the same things over and over again these optimizations can start to become noticeable (Specifically for TimerHandles and Normal Handles).
If I need to make any changes or remove or edit comments please let me know. I have today and tomorrow off from my parttime job so I should be able to reply rather quickly.
I may not have the ability to run my own test locally since I wrote this from a windows laptop same as with winloop so please let me know if something does not work correctly and I will do my best to fix it.