FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Perform NamedEvaluation of Anonymous Functions in Logical Assignment by jridgewell · Pull Request #11658 · babel/babel · GitHub

Repository navigation

Perform NamedEvaluation of Anonymous Functions in Logical Assignment - #11658

Merged
nicolo-ribaudo merged 1 commit into
babel:masterfrom
jridgewell:revert-11370
Jun 3, 2020
Merged

nicolo-ribaudo merged 1 commit into
babel:masterfrom
jridgewell:revert-11370

Conversation

Copy link
Copy Markdown
Member
Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This is a partial revert of #11370, updating the tests to match the new consensus.

I want to thank @arku for the initial PR!

This is a partial revert of babel#11370, updating the tests to match the [new consensus](babel/proposals#66 (comment)).

codesandbox-ci Bot commented Jun 1, 2020

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f62ed55:

Sandbox Source
inspiring-hill-17gls Configuration
zealous-maxwell-09don Configuration

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23357/

existentialism added the PR: Spec Compliance 👓 A type of pull request used for our changelog categories label Jun 2, 2020

Copy link
Copy Markdown
Member

I'm glad to see that Babel's implementation helped finding this spec change 😄

nicolo-ribaudo merged commit a3f0089 into babel:master Jun 3, 2020

Copy link
Copy Markdown
Member

I had to edit the commit name because it was too long

github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 3, 2020
github-actions Bot locked as resolved and limited conversation to collaborators Sep 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Logical Assignment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL