FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Expose inspectSwarmNodeCmd through DockerClient by kush2439p · Pull Request #2673 · docker-java/docker-java · GitHub

Expose inspectSwarmNodeCmd through DockerClient - #2673

Open
kush2439p wants to merge 1 commit into
docker-java:mainfrom
kush2439p:agent/expose-inspect-swarm-node-command
Open

Expose inspectSwarmNodeCmd through DockerClient#2673
kush2439p wants to merge 1 commit into
docker-java:mainfrom
kush2439p:agent/expose-inspect-swarm-node-command

Conversation

Copy link
Copy Markdown

Summary

  • expose the existing InspectSwarmNodeCmd through DockerClient
  • delegate the new client method and wire it to the existing command implementation and executor
  • add swarm integration coverage that inspects a node by ID

Root cause

The command interface, implementation, and executor already existed, but DockerClient and DockerClientDelegate did not expose a factory method. Consumers therefore could not invoke the command through the public client API.

Impact

Consumers can now call dockerClient.inspectSwarmNodeCmd(nodeId).exec() consistently with the existing list, update, and remove swarm-node commands.

Verification

  • mvn -pl docker-java-api,docker-java-core -am test -DskipITs -Dmaven.javadoc.skip=true
  • mvn -pl docker-java -am test-compile -DskipITs -Dmaven.javadoc.skip=true
  • git diff --check
  • Full mvn clean install -DskipITs passed through the API, core, transport TCK, Netty, and Jersey modules; it stopped in the existing OkHttp Docker-dependent TCK because no local Docker daemon was available.

Fixes #2373

kush2439p requested a review from a team as a code owner August 16, 2026 13:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DockerClient missing the "inspectSwarmNodeCmd()" command

1 participant


Back | FazBrowse Home | New Git URL