ref(aiohttp): Remove dead segment name code by mjq · Pull Request #7284 · getsentry/sentry-python · GitHub

The aiohttp integration currently has a dead branch that looks live:

sentry-python/sentry_sdk/integrations/aiohttp.py

Lines 341 to 356 in 8e6d73b

    
           if name is not None: 
        
               current_span = sentry_sdk.get_current_span() 
        
               if isinstance(current_span, StreamedSpan) and not isinstance( 
        
                   current_span, NoOpStreamedSpan 
        
               ): 
        
                   current_span._segment.name = name 
        
                   current_span._segment.set_attribute( 
        
                       "sentry.segment.name.source", 
        
                       SEGMENT_SOURCE_FOR_STYLE[integration.transaction_style].value, 
        
                   ) 
        
               else: 
        
                   current_scope = sentry_sdk.get_current_scope() 
        
                   current_scope.set_transaction_name( 
        
                       name, 
        
                       source=SOURCE_FOR_STYLE[integration.transaction_style], 
        
                   )

isinstance(current_span, StreamedSpan) is always false, so the first branch never matches. sentry_sdk.get_current_span() does not return StreamedSpans. (It reads from scope.span, but the streamed span is in scope.streamed_span).

This doesn't functionally matter, because even though we always fall through to the else branch, set_transaction_name already handles the streamed span case (including the name and source). This is tested in test_transaction_style_span_streaming already.

Remove the misleading branch.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 985bfad. Configure here.

Codecov Results 📊

✅ 119060 passed | ⏭️ 6762 skipped | Total: 125822 | Pass Rate: 94.63% | Execution Time: 442m 34s

📊 Comparison with Base Branch

Metric	Change
Total Tests	—
Passed Tests	—
Failed Tests	—
Skipped Tests	—

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2483 uncovered lines.
✅ Project coverage is 90.3%. Comparing base (base) to head (head).

Coverage diff

@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.29%    90.30%    +0.01%
==========================================
  Files          193       193         —
  Lines        25601     25596        -5
  Branches      9436      9434        -2
==========================================
+ Hits         23116     23113        -3
- Misses        2485      2483        -2
- Partials      1435      1434        -1

Generated by Codecov Action

cursor Bot reviewed Aug 28, 2026

View reviewed changes

mjq marked this pull request as ready for review August 28, 2026 14:21

mjq requested a review from a team as a code owner August 28, 2026 14:21

mjq marked this pull request as draft August 28, 2026 14:25

mjq force-pushed the mjq/aiohttp-streamedspan-branch branch from 985bfad to ad70524 Compare August 28, 2026 14:34

mjq changed the title fix(aiohttp): Correctly apply segment/transaction name in streaming mode ref(aiohttp): Remove dead segment name code Aug 28, 2026

mjq force-pushed the mjq/aiohttp-streamedspan-branch branch from 5ee183d to 566edcf Compare August 28, 2026 14:39

mjq marked this pull request as ready for review August 28, 2026 14:40

ref(aiohttp): Remove dead segment name code

c41605f

mjq force-pushed the mjq/aiohttp-streamedspan-branch branch from 566edcf to c41605f Compare August 28, 2026 14:48

mjq mentioned this pull request Aug 28, 2026

feat(integrations): Add http.route attribute to server spans #7183

Draft

ref(aiohttp): Remove dead segment name code by mjq · Pull Request #7284 · getsentry/sentry-python · GitHub

Uh oh!

ref(aiohttp): Remove dead segment name code - #7284

ref(aiohttp): Remove dead segment name code#7284
mjq wants to merge 1 commit into
masterfrom
mjq/aiohttp-streamedspan-branch

mjq commented Aug 28, 2026 •
edited
Loading

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

github-actions Bot commented Aug 28, 2026 •
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	if name is not None:
	current_span = sentry_sdk.get_current_span()
	if isinstance(current_span, StreamedSpan) and not isinstance(
	current_span, NoOpStreamedSpan
	):
	current_span._segment.name = name
	current_span._segment.set_attribute(
	"sentry.segment.name.source",
	SEGMENT_SOURCE_FOR_STYLE[integration.transaction_style].value,
	)
	else:
	current_scope = sentry_sdk.get_current_scope()
	current_scope.set_transaction_name(
	name,
	source=SOURCE_FOR_STYLE[integration.transaction_style],
	)

ref(aiohttp): Remove dead segment name code by mjq · Pull Request #7284 · getsentry/sentry-python · GitHub

Uh oh!

ref(aiohttp): Remove dead segment name code - #7284

ref(aiohttp): Remove dead segment name code#7284mjq wants to merge 1 commit intomastergetsentry/sentry-python:masterfrom mjq/aiohttp-streamedspan-branchgetsentry/sentry-python:mjq/aiohttp-streamedspan-branchCopy head branch name to clipboard

Conversation

mjq commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Results 📊

📊 Comparison with Base Branch

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ref(aiohttp): Remove dead segment name code#7284
mjq wants to merge 1 commit into
masterfrom
mjq/aiohttp-streamedspan-branch

mjq commented Aug 28, 2026 •
edited
Loading

github-actions Bot commented Aug 28, 2026 •
edited
Loading