feat(pyreqwest): Support data_collection filtering for URL query params - #7288
Open
ericapisani wants to merge 1 commit into
Open
feat(pyreqwest): Support data_collection filtering for URL query params#7288ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Previously the pyreqwest integration only redacted URL query params and fragments based on send_default_pii, always leaking the full query string when PII collection was enabled. Now the data_collection experiment's url_query_params allow/deny list is applied to spans and breadcrumbs, matching the behaviour already shipped for httpx. Legacy (non span-streaming) breadcrumbs still report the bare URL without the query string, but the query value itself is filtered consistently with span streaming. Fixes PY-2746 Fixes #7281
Copy link
Copy Markdown
Sorry, something went wrong.
ericapisani
marked this pull request as ready for review
August 28, 2026 18:06
Copy link
Copy Markdown
Contributor
Codecov Results 📊✅ 120425 passed | ⏭️ 6762 skipped | Total: 127187 | Pass Rate: 94.68% | Execution Time: 435m 18s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2485 uncovered lines.
@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.29% 90.31% +0.02%
==========================================
Files 193 193 —
Lines 25601 25653 +52
Branches 9436 9456 +20
==========================================
+ Hits 23116 23168 +52
- Misses 2485 2485 —
- Partials 1435 1441 +6Generated by Codecov Action |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the pyreqwest integration only redacted URL query params
and fragments based on send_default_pii, always leaking the full
query string when PII collection was enabled. Now the
data_collection experiment's url_query_params allow/deny list is
applied to spans and breadcrumbs, matching the behaviour already
shipped for httpx.
Legacy (non span-streaming) breadcrumbs still report the bare URL
without the query string, but the query value itself is filtered
consistently with span streaming.
Fixes PY-2746
Fixes #7281