Test with M1 macOS CI runner by EliahKagan · Pull Request #1817 · gitpython-developers/GitPython · GitHub

This adds CI test jobs that run on ARM processors. Specifically, it adds macos-14 as a value for os in the CI test matrix. The new macOS 14 runners use Apple Silicon M1 systems (64-bit ARM CPUs), allowing GitPython to be tested on AArch64/ARM64 actions/python-versions builds of Python, such as python-3.12.1-darwin-arm64.tar.gz.

Not all versions of Python that GitPython supports are currently available via actions/setup-python:

Python 3.7 builds that can run on macos-14 runners are unlikely ever to be available, because 3.7 is end-of-life.
Python 3.8 and Python 3.9 builds are currently unavailable, but this may be remedied; it is being tracked in Python <3.10 not available on new macOS M1 runners actions/setup-python#808.

Therefore, the new macos-14 jobs this creates are only for Python 3.10, Python 3.11, and Python 3.12. This is achieved by using exclude for the earlier versions. This way, a macos-14 job would automatically be created when 3.13 is added to python-version. (The first commit doesn't exclude anything, to verify that 3.7, 3.8, and 3.9 error out as expected. Then the second commit adds the exclusions.) If this PR is accepted, then I recommend 3.8 and 3.9 be added later, if and when they become easily available.

This does not remove or change any pre-existing jobs, but maybe it should. That is to say that this does not change macos-13 to macos-14, but instead just adds three macos-14 jobs. All six of the old macos-13 jobs, which run on Intel-based macOS 14 runners, are retained. Having nine macOS jobs may be considered excessive; even if not, builds for Python 3.8 and 3.9 may become available, and having eleven may be considered excessive. Options include:

Rejecting or deferring this change completely.
Taking this it as is but revisiting the matter when builds of more Python versions become available.
Changing this to omit some versions. If that is done, the question is which ones. We could avoid doubling up Python version on macOS, but there may be a benefit to this, as it would make it easier to guess that a failure is related to the architecture. (Though we still would not know immediately because it is a different version of macOS as well.)

This adds macos-14 as a value for "os". The new macOS 14 runners use Apple Silicon M1 systems (64-bit ARM CPUs), allowing GitPython to be tested on ARM64 actions/python-versions builds of Python, such as python-3.12.1-darwin-arm64.tar.gz. https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/ https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ This commit doesn't exclude any `os`/`python-version` combinations, even though not all versions of Python that GitPython supports are currently available via the setup-python (and 3.7 builds are very unlikely ever to be available for macos-14). This is to verify that the currently unsupported versions are 3.7, 3.8, 3.9, and no others. The next commit will exclude the unavailable versions.

Some versions of Python do not currently have builds available via actions/setup-python for the Apple Silicon M1 (64-bit ARM) runner used for macos-14. This excludes those. - Python 3.7 is EoL and builds for it are no likely to be provided for newly available platforms on GitHub Actions. - Python 3.8 and 3.9 are still supported by the Python Software Foundation. Builds for them are not currently avaialable on the GHA M1 runners, but it appears this may not be intentional. See actions/setup-python#808. If those versions become available, then they can be reenabled. - Later versions of Python are available.

Thanks a million!

love this change and would love to try it in the hopes that MacOS runners never will be a problem. It's also interesting to see how they are the fastest machines of the bunch, and how the python version seems to make a difference as well.

Merging - let's wait and see.

It's also interesting to see how they are the fastest machines of the bunch,

This makes sense to me because I've heard the M1 is pretty fast.

and how the python version seems to make a difference as well.

Although I expect that in general because there have been efforts in the last few versions of CPython to improve performance, I'm not sure if we're observing that or not, between the Python versions used on the macos-14 runners. Which Python versions are faster or slower than the others in the pytest step seems to be different in different runs, comparing the results in 8342f82, 9ad28c3, and 6cba89f.

I see, what I looked at might have been coincidence - I also thought that it's probably just luck as the jump between two python versions certainly won't speed anything up by a factor of 2 😅.

These were excluded in 9ad28c3 (gitpython-developers#1817) due to actions/setup-python#808, which was later fixed by actions/python-versions#259. Because Python 3.7 has been end-of-life for a while, it is very unlikely to have AArch64 builds added in python-versions for use on GitHub Actions CI runners (preinstalled or via setup-python).

EliahKagan added 2 commits February 5, 2024 23:03

EliahKagan marked this pull request as ready for review February 6, 2024 10:35

Byron merged commit 6cba89f into gitpython-developers:main Feb 6, 2024

EliahKagan deleted the ci-arm branch February 6, 2024 18:31

EliahKagan mentioned this pull request Jul 24, 2024

Enable Python 3.8 and 3.9 on M1 runners #1944

Merged

Test with M1 macOS CI runner by EliahKagan · Pull Request #1817 · gitpython-developers/GitPython · GitHub

Uh oh!

Uh oh!

Test with M1 macOS CI runner - #1817

Test with M1 macOS CI runner#1817
Byron merged 2 commits into
gitpython-developers:mainfrom
EliahKagan:ci-arm

EliahKagan commented Feb 6, 2024 •
edited
Loading

Uh oh!

Uh oh!

Byron commented Feb 6, 2024

Uh oh!

EliahKagan commented Feb 7, 2024

Uh oh!

Byron commented Feb 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Test with M1 macOS CI runner by EliahKagan · Pull Request #1817 · gitpython-developers/GitPython · GitHub

Uh oh!

Uh oh!

Test with M1 macOS CI runner - #1817

Test with M1 macOS CI runner#1817Byron merged 2 commits intogitpython-developers:maingitpython-developers/GitPython:mainfrom EliahKagan:ci-armEliahKagan/GitPython:ci-armCopy head branch name to clipboard

Conversation

EliahKagan commented Feb 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Byron commented Feb 6, 2024

Uh oh!

EliahKagan commented Feb 7, 2024

Uh oh!

Byron commented Feb 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Test with M1 macOS CI runner#1817
Byron merged 2 commits into
gitpython-developers:mainfrom
EliahKagan:ci-arm

EliahKagan commented Feb 6, 2024 •
edited
Loading