FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: do not shut down executor when WatchDog is shut down by chrisribble · Pull Request #871 · googleapis/gax-java · GitHub

This repository was archived by the owner on Sep 26, 2023. It is now read-only.
/ gax-java Public archive

fix: do not shut down executor when WatchDog is shut down - #871

Merged
igorbernstein2 merged 1 commit into
googleapis:masterfrom
chrisribble:master
Feb 18, 2020
Merged

fix: do not shut down executor when WatchDog is shut down#871
igorbernstein2 merged 1 commit into
googleapis:masterfrom
chrisribble:master

Conversation

Copy link
Copy Markdown
Contributor

Fixes #870

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 13, 2020

codecov Bot commented Feb 13, 2020
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #871 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #871      +/-   ##
============================================
- Coverage     78.62%   78.62%   -0.01%     
  Complexity     1163     1163              
============================================
  Files           203      203              
  Lines          5142     5141       -1     
  Branches        413      413              
============================================
- Hits           4043     4042       -1     
  Misses          925      925              
  Partials        174      174
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/api/gax/rpc/Watchdog.java 80.34% <ø> (-0.17%) 11 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee90c2c...fa2ff44. Read the comment docs.

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 13, 2020

igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

Thanks for fixing this

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WatchDog shuts down ExecutorService from FixedExecutorProvider

3 participants


Back | FazBrowse Home | New Git URL