fix(storage): only backoff before resume attempts - #14427
Merged
coryan merged 2 commits intoJul 3, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #14427 +/- ##
=======================================
Coverage 93.58% 93.59%
=======================================
Files 2313 2313
Lines 206951 206983 +32
=======================================
+ Hits 193680 193716 +36
+ Misses 13271 13267 -4 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
`storage::Client::ReadObject()` resumes a download that gets interrupted (controlled by policy). On the first resume attempt, the library does not back off (sleep), becuase there is no reason to believe the problem is load related. If the first resume fails, the library backsoff before each attempt, as the problem might be load related after this point. The library was *also* backing off before issuing the first `Read()` on the newly created source of data. That effectively doubles the backoff time, and leaves the resumed connection idle for (potentially) a long time when there are multiple resume attempts needed.
coryan
force-pushed
the
fix-storage-only-sleep-before-resume-attempts
branch
from
5e65592 to
eacd9e4
Compare
July 3, 2024 18:19
coryan
marked this pull request as ready for review
July 3, 2024 18:42
dbolduc
approved these changes
Jul 3, 2024
Comment thread
google/cloud/storage/internal/retry_object_read_source_test.cc
Outdated
| HttpResponse{100, "", {}}})); | ||
| EXPECT_CALL(*source, Read).WillOnce(Return(TransientError())); | ||
| // No backoffs to resume after a (partially) successful request: | ||
| // EXPECT_CALL(backoff, Call).Times(1); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
remove?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Done.
Sorry, something went wrong.
| @@ -222,21 +224,22 @@ TEST(RetryObjectReadSourceTest, BackoffPolicyResetOnSuccess) { | |||
|
|
|||
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
s/closed/cloned/ on L217
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Done.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
storage::Client::ReadObject() resumes a download that gets
interrupted (controlled by policy). Before making a resume attempt, the
library backsoff in case the problem is load related. The library was
also backing off before issuing the first Read() on the newly
created source of data. That effectively doubles the backoff time.
Fixes #14424
This change is