fix: disconnect low-level response on construction failure to prevent connection leak - #2178
Open
insaf021 wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
… connection leak Fixes googleapis#2177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpResponse construction can throw a RuntimeException. The existing finally block in
HttpRequest.execute() closes the content stream in that case but never calls
LowLevelHttpResponse.disconnect(), leaving the socket open.
Changes
fails; added null-guard and isolated getContent() failures so they don't suppress
the disconnect() call.
Notes
Pre-existing bug, unrelated to the security hardening work (redirect credential stripping,
CRLF validation, XXE hardening) — those are separate PRs.
Fixes #2177 ☕️