FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(samples): bug fix for removing buckets from bq. by dfirova · Pull Request #548 · googleapis/java-retail · GitHub

This repository was archived by the owner on Oct 3, 2023. It is now read-only.
/ java-retail Public archive

fix(samples): bug fix for removing buckets from bq. - #548

Merged
Sita04 merged 14 commits into
googleapis:mainfrom
dfirova:GRST-258-remove-buckets
Sep 26, 2022
ConversationCommits (14)ChecksFiles changed
Merged

fix(samples): bug fix for removing buckets from bq.#548
Sita04 merged 14 commits into
googleapis:mainfrom
dfirova:GRST-258-remove-buckets

Conversation

dfirova commented Sep 20, 2022

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

dfirova requested review from a team September 20, 2022 05:59
product-auto-label Bot added size: m Pull request size is medium. api: retail Issues related to the googleapis/java-retail API. samples Issues that are directly related to samples. labels Sep 20, 2022
Merge branch 'main' into GRST-258-remove-buckets
5b2b753 
# Conflicts:
#	samples/interactive-tutorials/src/main/java/product/setup/ProductsCreateBigqueryTable.java
product-auto-label Bot added size: xs Pull request size is extra small. and removed size: m Pull request size is medium. labels Sep 20, 2022

Sita04 commented Sep 20, 2022

Copy link
Copy Markdown
Contributor

Shadow reviewer. Tagging @kurtisvg for the second review.

dfirova requested a review from Sita04 September 20, 2022 10:33
Sita04 approved these changes Sep 20, 2022
View reviewed changes

Sita04 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Minor nits. LGTM otherwise.

Comment thread samples/interactive-tutorials/src/main/java/product/ImportProductsBigQueryTable.java Outdated
Comment thread samples/interactive-tutorials/src/main/java/product/ImportProductsBigQueryTable.java Outdated
dfirova and others added 2 commits September 20, 2022 15:22
pr fix: added dot to importproductsbigquerytable.
7944043 
Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
pr fix: added dot in importproductsbigquerytable
762c9d9 
Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
dfirova requested a review from Sita04 September 20, 2022 12:23
meltsufin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2022
kurtisvg added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 21, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 21, 2022
kurtisvg added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 21, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 21, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2022

dfirova commented Sep 22, 2022

Copy link
Copy Markdown
Contributor Author

@kurtisvg owlbot failed, but I can't view the details of what went wrong. Would like to know in order to fix any issues

kurtisvg commented Sep 22, 2022

Copy link
Copy Markdown

@dfirova it looks like the logs say it's because it's on a fork:

Step #8: See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md"
Step #8: git pull --no-verify
Step #8: git push --no-verify
Step #8: fatal: unable to access 'https://github.com/dfirova/java-retail.git/': Failed to connect to github.com port 443 after 130249 ms: Operation timed out
Step #8: owl-bot.js commit-post-processor-update
Step #8: 
Step #8: Runs either `git commit -m "Updates from OwlBot"` or `git commit --amend
Step #8: --no-edit`
Step #8: depending on the squash flag in .OwlBot.yaml.
Step #8: 
Step #8: Run this command in the root directory of a client library repository after
Step #8: running the post processor.
Step #8: 
Step #8: Options:
Step #8:   --help          Show help                                            [boolean]
Step #8:   --version       Show version number                                  [boolean]
Step #8:   --dest-repo     The PR's destination repo (e.g., googleapis/foo)
Step #8:                                                              [string] [required]
Step #8:   --pr            The pull request number                    [number] [required]
Step #8:   --github-token  Short-lived GitHub token.                  [string] [required]
Step #8:   --repo-path     Local path to the repository
Step #8:                                     [string] [default: "/workspace/java-retail"]
Step #8: 
Step #8: Error: Command failed: git push --no-verify
Step #8: fatal: unable to access 'https://github.com/dfirova/java-retail.git/': Failed to connect to github.com port 443 after 130249 ms: Operation timed out
Step #8: 
Step #8:     at checkExecSyncError (child_process.js:790:11)
Step #8:     at Object.execSync (child_process.js:863:15)
Step #8:     at cmd (/usr/src/app/build/src/cmd.js:44:29)
Step #8:     at commitPostProcessorUpdate (/usr/src/app/build/src/bin/commands/commit-post-processor-update.js:146:5)
Step #8:     at processTicksAndRejections (internal/process/task_queues.js:95:5) {
Step #8:   status: 128,
Step #8:   signal: null,
Step #8:   output: [
Step #8:     null,
Step #8:     <Buffer >,
Step #8:     <Buffer 66 61 74 61 6c 3a 20 75 6e 61 62 6c 65 20 74 6f 20 61 63 63 65 73 73 20 27 68 74 74 70 73 3a 2f 2f 67 69 74 68 75 62 2e 63 6f 6d 2f 64 66 69 72 6f 76 ... 99 more bytes>
Step #8:   ],
Step #8:   pid: 42,
Step #8:   stdout: <Buffer >,
Step #8:   stderr: <Buffer 66 61 74 61 6c 3a 20 75 6e 61 62 6c 65 20 74 6f 20 61 63 63 65 73 73 20 27 68 74 74 70 73 3a 2f 2f 67 69 74 68 75 62 2e 63 6f 6d 2f 64 66 69 72 6f 76 ... 99 more bytes>
Step #8: }
Finished Step #8
ERROR
ERROR: build step 8 "gcr.io/cloud-devrel-public-resources/owlbot-cli" failed: step exited with non-zero status: 1

@SurferJeffAtGoogle is there some additional step they need to take ?

suztomo commented Sep 23, 2022

Copy link
Copy Markdown
Member

"Operation timed out" in the message. Retrying with "owlbot:run" label.

suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2022

suztomo commented Sep 23, 2022

Copy link
Copy Markdown
Member

OwlBot - successfully ran 9 steps

kurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 23, 2022
yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 23, 2022
Sita04 merged commit c407fe3 into googleapis:main Sep 26, 2022
release-please Bot mentioned this pull request Sep 26, 2022
Merged
gcf-merge-on-green Bot pushed a commit that referenced this pull request Oct 5, 2022
chore(main): release 2.5.1 (#547)
de4380f 
🤖 I have created a release *beep* *boop*
---


## [2.5.1](https://togithub.com/googleapis/java-retail/compare/v2.5.0...v2.5.1) (2022-10-03)


### Bug Fixes

* **samples:** Bug fix for removing buckets from bq. ([#548](https://togithub.com/googleapis/java-retail/issues/548)) ([c407fe3](https://togithub.com/googleapis/java-retail/commit/c407fe3581a39598d86eb968b2650c8e8f4e8063))
* **samples:** Bug fix for setup script ([#549](https://togithub.com/googleapis/java-retail/issues/549)) ([abc4b3e](https://togithub.com/googleapis/java-retail/commit/abc4b3eab3ae664ceeb4de54b3623406aac85950))
* **samples:** Lro added out-of-order step. ([#539](https://togithub.com/googleapis/java-retail/issues/539)) ([2befbb1](https://togithub.com/googleapis/java-retail/commit/2befbb1349131345488890ad33eb20ba91692f1b))
* **samples:** Removed delays on LRO ([#527](https://togithub.com/googleapis/java-retail/issues/527)) ([934c6b4](https://togithub.com/googleapis/java-retail/commit/934c6b4dd259e18d1aee88abbffd4b88d1b70343))
* **samples:** Replaced your-project-id with default. ([#541](https://togithub.com/googleapis/java-retail/issues/541)) ([f1b2397](https://togithub.com/googleapis/java-retail/commit/f1b23977282b213029533756449213d591673f62))
* **samples:** Updating both json files. ([#540](https://togithub.com/googleapis/java-retail/issues/540)) ([22386d5](https://togithub.com/googleapis/java-retail/commit/22386d50f0cf66449236562e241bce212ada70ea))


### Dependencies

* Update dependency cachetools to v5 ([#566](https://togithub.com/googleapis/java-retail/issues/566)) ([95ea349](https://togithub.com/googleapis/java-retail/commit/95ea3490140be099b54deaa0ff74ad4659869a92))
* Update dependency certifi to v2022.9.24 ([#568](https://togithub.com/googleapis/java-retail/issues/568)) ([45253be](https://togithub.com/googleapis/java-retail/commit/45253be7a091375b790bb229a9ca55a65b4a3f32))
* Update dependency charset-normalizer to v2.1.1 ([#556](https://togithub.com/googleapis/java-retail/issues/556)) ([f244afc](https://togithub.com/googleapis/java-retail/commit/f244afcf0a27c84a489ed3621201b9e18d168cdb))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.1 ([#542](https://togithub.com/googleapis/java-retail/issues/542)) ([e9e88d3](https://togithub.com/googleapis/java-retail/commit/e9e88d3014f1e35655b76e0f834889a37ac02f00))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#577](https://togithub.com/googleapis/java-retail/issues/577)) ([a963dc6](https://togithub.com/googleapis/java-retail/commit/a963dc6cf0b4ef93ee5bf411cf5f97a98062e633))
* Update dependency com.google.cloud:google-cloud-storage to v2.12.0 ([#543](https://togithub.com/googleapis/java-retail/issues/543)) ([24386db](https://togithub.com/googleapis/java-retail/commit/24386db488f724d4e10965cd25605f3af2ed403a))
* Update dependency gcp-releasetool to v1.8.8 ([#569](https://togithub.com/googleapis/java-retail/issues/569)) ([45a7e22](https://togithub.com/googleapis/java-retail/commit/45a7e22e2793aa21b9044865944e28d436cfa9d6))
* Update dependency google-api-core to v2.10.1 ([#558](https://togithub.com/googleapis/java-retail/issues/558)) ([8712708](https://togithub.com/googleapis/java-retail/commit/8712708260b380e4856a34aa03434448190ce5dd))
* Update dependency google-auth to v2.11.1 ([#570](https://togithub.com/googleapis/java-retail/issues/570)) ([0b4e3a5](https://togithub.com/googleapis/java-retail/commit/0b4e3a5d1b0fecdeffc9c1f160ea9b08fe220300))
* Update dependency google-cloud-core to v2.3.2 ([#554](https://togithub.com/googleapis/java-retail/issues/554)) ([98db758](https://togithub.com/googleapis/java-retail/commit/98db758b0b9d12281b150a341790eecd4d5664a2))
* Update dependency google-cloud-storage to v2.5.0 ([#559](https://togithub.com/googleapis/java-retail/issues/559)) ([01ddcf9](https://togithub.com/googleapis/java-retail/commit/01ddcf9b16dce0ab80430ac20938ff4b9216b382))
* Update dependency google-crc32c to v1.5.0 ([#560](https://togithub.com/googleapis/java-retail/issues/560)) ([e877900](https://togithub.com/googleapis/java-retail/commit/e87790009c7f5b3bf131f1db04ad97713b6b6c8c))
* Update dependency googleapis-common-protos to v1.56.4 ([#555](https://togithub.com/googleapis/java-retail/issues/555)) ([1cb27b3](https://togithub.com/googleapis/java-retail/commit/1cb27b3ee903c2104911c27217b78bd9cacea26a))
* Update dependency importlib-metadata to v4.12.0 ([#561](https://togithub.com/googleapis/java-retail/issues/561)) ([9f4d04b](https://togithub.com/googleapis/java-retail/commit/9f4d04b23e909829b129f2acc2d6061e8894a20f))
* Update dependency jeepney to v0.8.0 ([#571](https://togithub.com/googleapis/java-retail/issues/571)) ([5ca90a0](https://togithub.com/googleapis/java-retail/commit/5ca90a04c6f0c8de9f90675b6ef91612701a15d8))
* Update dependency jinja2 to v3.1.2 ([#572](https://togithub.com/googleapis/java-retail/issues/572)) ([0cf30ee](https://togithub.com/googleapis/java-retail/commit/0cf30eee9ba1256164255444344b4be5d09a5143))
* Update dependency keyring to v23.9.3 ([#573](https://togithub.com/googleapis/java-retail/issues/573)) ([ab772da](https://togithub.com/googleapis/java-retail/commit/ab772dafca75ae557b8f2558e32da6899082b2c0))
* Update dependency markupsafe to v2.1.1 ([#553](https://togithub.com/googleapis/java-retail/issues/553)) ([fce0ade](https://togithub.com/googleapis/java-retail/commit/fce0ade246a75dc35b05e106f1b7f5aa73fc516e))
* Update dependency protobuf to v3.20.2 ([#574](https://togithub.com/googleapis/java-retail/issues/574)) ([7fa228e](https://togithub.com/googleapis/java-retail/commit/7fa228eb669cb0b59e64ca0d2e8641e01df05a9e))
* Update dependency protobuf to v4 ([#567](https://togithub.com/googleapis/java-retail/issues/567)) ([cf6be4c](https://togithub.com/googleapis/java-retail/commit/cf6be4ceff0cd39af95b8e0201aa1657579b21a0))
* Update dependency pyjwt to v2.5.0 ([#562](https://togithub.com/googleapis/java-retail/issues/562)) ([96ec337](https://togithub.com/googleapis/java-retail/commit/96ec337e1ec00811b23f1f509156749d2a062301))
* Update dependency requests to v2.28.1 ([#563](https://togithub.com/googleapis/java-retail/issues/563)) ([8bd27c1](https://togithub.com/googleapis/java-retail/commit/8bd27c1a264132f932701ae5b5f14b6540bdb8a1))
* Update dependency typing-extensions to v4.3.0 ([#564](https://togithub.com/googleapis/java-retail/issues/564)) ([7c0cd75](https://togithub.com/googleapis/java-retail/commit/7c0cd7590d9d52acf7c82ecc1cbd8df85ba5e7ca))
* Update dependency zipp to v3.8.1 ([#565](https://togithub.com/googleapis/java-retail/issues/565)) ([4c30271](https://togithub.com/googleapis/java-retail/commit/4c302718f919d231d02fa5415a45825aab38fe18))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
chenlei1216 chenlei1216 approved these changes
Sita04 Sita04 approved these changes
kurtisvg kurtisvg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

Sita04

Labels

api: retail Issues related to the googleapis/java-retail API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL