Fix cell magic detection after leading comments - #15391
Open
aprylewu wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Remove leading comment-only and blank lines only when the first remaining line is a cell magic. Apply the cleanup after prompt stripping so pasted transcripts use the same transformation and completeness rules. Preserve ordinary Python input and cell-magic bodies. Document the changed interpretation of programmatically registered line magics named with a leading percent sign. Fixes ipython#15312 🤖🤖 Prepared with AI assistance. Signed-off-by: Mingyang Wu <129849514+aprylewu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comment before a cell magic currently sends it through the line-magic parser. For example:
Add a cleanup transform that removes leading comment-only and blank lines when the next line starts with %%. Run it after both prompt strippers so pasted Python and IPython transcripts receive the same treatment. Preserve the magic body and leading comments in ordinary Python or line-magic cells.
Add regressions for pasted prompts, indentation, help syntax, cell-completion checks, body preservation, and execution through InteractiveShell. The release note documents the change for programmatically registered line magics whose names begin with %.
This follows the cleanup approach discussed in #15312 and the unmerged #15316.
Fixes #15312
🤖🤖 Prepared with AI assistance.