fix: keep debugjava executable on POSIX - #1663
Open
sama Pyb (Pybsama) wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Revalidated the exact PR patch against current upstream main 40a2ff1 on macOS/arm64:
I also tried GitHub's server-side update-branch operation, but it was rejected before changing the head because the intervening upstream commits modify .github/workflows/build.yml and the current OAuth token lacks workflow scope. I did not expand credentials; the validated public patch and PR head remain unchanged. |
Sorry, something went wrong.
sama Pyb (Pybsama)
marked this pull request as ready for review
August 29, 2026 05:32
sama Pyb (Pybsama)
requested review from
Changyong Gong (chagong),
Sheng Chen (jdneo),
Jinbo Wang (testforstephen) and
wenyt (wenytang-ms)
as code owners
August 29, 2026 05:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preserving all other ordinary and special Unix permission bits
Windows no-op path
Why
The official VSIX is built on Windows. Version 0.59.0 consequently shipped
debugjava with CRLF line endings and without usable execute permission on
Linux. Changing only the Git mode would not survive that build path, while
changing only the line-ending policy would still leave the installed wrapper
non-executable.
Fixes #1662.
Tests
The repository-pinned @vscode/test-electron 2.4.1 resolves the old macOS
binary name Electron, while the downloaded VS Code 1.131.0 bundle contains
Contents/MacOS/Code. I ran the same compiled extension suite through
runTests with that actual executable path; all 33 tests passed.