QuickFix Format_Badbase64Char #2953 - #2957
Open
lordyavin wants to merge 1 commit into
Open
lordyavin wants to merge 1 commit into
lordyavin wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Add error handling for Convert.FromBase64String to not crash in case of bad format.
Copy link
Copy Markdown
Owner
|
TBH I'm pretty concerned with this fix as it silently swallows the invalid data. ReadBase64 is such a basic method that it's hard to decide what to do with invalid data here. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
It's a quick fix and not a sophisticated error handling solution. You may handle it differently and show a dialog to the user which explains the problem and where it is. IMHO not opening the DB is very inconvenient. |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add error handling for Convert.FromBase64String to not crash in case of bad format.