Feature: CGRect extensions corners and edges + center setter - #1245
Open
ihar-shalouski wants to merge 4 commits into
Open
ihar-shalouski wants to merge 4 commits into
ihar-shalouski wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…enterRight, .bottomLeft, .bottomCenter, .bottomRight allowing user easier access and modify rectangle's geometry
ihar-shalouski
marked this pull request as ready for review
September 10, 2025 11:25
guykogus
requested changes
Nov 11, 2025
guykogus
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice, just 1 little comment.
Sorry, something went wrong.
Comment thread
Tests/CoreGraphicsTests/CGRectExtensionsTests.swift
| } | ||
|
|
||
| func testCenterSet() { | ||
| var rect = CGRect(x: 10, y: 20, width: 30, height: 40) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
No need to keep recreating this, create a constant and reuse it.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@ihar-shalouski this is so close to being mergeable. Do you want to finish this? |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Requested changes must be addressed to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a setter for CGRect.center.
Added CGRect corners and edges getters/setters. topLeft, topCenter, topRight, centerLeft, centerRight, bottomLeft, bottomCenter, bottomRight.
Checklist