fix: NewsletterSignup crashes on undefined signupSources - #1188
Open
sentry[bot] wants to merge 1 commit into
Open
fix: NewsletterSignup crashes on undefined signupSources#1188sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 937bc92 | Commit Preview URL Branch Preview URL |
Aug 28 2026, 11:02 PM |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a TypeError in the NewsletterSignup component where user?.signupSources.includes('newsletter') would crash if user was defined but user.signupSources was undefined. This happened for users whose accounts might not have the signupSources field initialized.
The fix adds optional chaining (?.) to signupSources, changing the expression to user?.signupSources?.includes('newsletter') ?? false. This ensures that if signupSources is undefined, the expression safely short-circuits without throwing an error, preventing the component from crashing.
Fixes TANSTACK-COM-4W6
This PR was automatically generated by Sentry. You can adjust this setting at any time.