feat(maths): add type validation and comprehensive tests for isEven - #1884
Open
sibalonecoding-code wants to merge 1 commit into
Open
feat(maths): add type validation and comprehensive tests for isEven#1884sibalonecoding-code wants to merge 1 commit into
sibalonecoding-code wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
sibalonecoding-code
requested review from
appgurueu and
raklaptudirm
as code owners
March 1, 2026 17:22
sibalonecoding-code
force-pushed
the
feature/robust-iseven
branch
from
67524a7 to
e3737fb
Compare
March 1, 2026 18:16
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #1884 +/- ##
==========================================
+ Coverage 85.91% 85.92% +0.01%
==========================================
Files 379 379
Lines 19778 19793 +15
Branches 3015 3021 +6
==========================================
+ Hits 16993 17008 +15
Misses 2785 2785 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
sibalonecoding-code
force-pushed
the
feature/robust-iseven
branch
from
dc1468c to
5c1e06c
Compare
March 2, 2026 10:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 2 approving reviews are required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
Summary of changes
I have improved the robustness of isEven and isEvenBitwise by adding strict type validation (throwing TypeError for non-numeric inputs like strings, null, or NaN).
I also updated the test suite to cover these new edge cases and included a property-based test with random values to ensure mathematical consistency across a wide range.
This is my first contribution but I hope that I didn't make any big mistake.